Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216408

Re: [PATCH 21/22] xfs: %pF is only for function pointers

Show all headers | View raw

On Mon, 31 Aug 2015 14:24:25 -0500
Scott Wood <scottwood@freescale.com> wrote:
 
> > Can you please look into why this change broke the tracing output
> > on x86-64 - if there is no obvious/easy fix for it, then I'm simply
> > going to revert it because having the tracing work correctly on
> > x86-64 is far more important to us than ppc64 or ia64....
> 
> It looks like the cause is that TP_printk() is not really printk() -- it 
> actually passes the format to userspace which has its own, not 100% 
> compatible implementation pretty_print() in tools/lib/traceevent/event-
> parse.c.  %pf in that function behaves like %ps in the kernel, and %ps is 
> absent.
> 

We can fix that with adding %ps to the traceevent library.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 21/22] xfs: %pF is only for function pointers Dave Chinner <david@fromorbit.com> - 2015-08-31 10:10 +0200
  Re: [PATCH 21/22] xfs: %pF is only for function pointers Scott Wood <scottwood@freescale.com> - 2015-08-31 21:30 +0200
    Re: [PATCH 21/22] xfs: %pF is only for function pointers Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 21:50 +0200
      Re: [PATCH 21/22] xfs: %pF is only for function pointers Scott Wood <scottwood@freescale.com> - 2015-08-31 22:00 +0200
        Re: [PATCH 21/22] xfs: %pF is only for function pointers Steven Rostedt <rostedt@goodmis.org> - 2015-08-31 22:10 +0200

csiph-web