Re: [PATCH] x86, vsyscall: add CONFIG to control default

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86, vsyscall: add CONFIG to control default
Date	2015-08-31 22:20 +0200
Message-ID	<q3DIB-1oI-1@gated-at.bofh.it> (permalink)
References	<pWP2b-4fa-35@gated-at.bofh.it> <pWQrf-6Be-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 12, 2015 at 7:23 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Wed, Aug 12, 2015 at 05:55:19PM -0700, Kees Cook wrote:
>> Most modern systems can run with vsyscall=none. In an effort to provide
>> a way for build-time defaults to lack legacy settings, this adds a new
>> CONFIG to select the type of vsyscall mapping to use, similar to the
>> existing "vsyscall" command line parameter.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Seems reasonable to me.  One question, though: is there *any* reason to
> choose "native" over "emulate"?  (Does "emulate" have a sufficient
> performance penalty to matter, and do people running old glibc really
> care about that performance while still not wanting to upgrade?)
> If there is a reason, could you please document it in the
> descriptions of the "native" and "emulate" options (as an upside and a
> downside, respectively)?  If there isn't, you might consider a patch to
> remove "native".

I think "native" is available out of an abundance of caution. Andy
left it available, though I'm not sure if he had plans to remove
"native" entirely.

Can someone from the x86 tree take this patch, or are there other
things to improve?

Thanks!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86, vsyscall: add CONFIG to control default Kees Cook <keescook@chromium.org> - 2015-08-31 22:20 +0200
  Re: [PATCH] x86, vsyscall: add CONFIG to control default Andy Lutomirski <luto@amacapital.net> - 2015-08-31 23:30 +0200
    Re: [PATCH] x86, vsyscall: add CONFIG to control default Kees Cook <keescook@chromium.org> - 2015-09-03 23:10 +0200

csiph-web