Re: [PATCH v2] sched: fix nohz.next_balance update

From	Vincent Guittot <vincent.guittot@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] sched: fix nohz.next_balance update
Date	2015-08-28 13:20 +0200
Message-ID	<q2pRn-1DC-9@gated-at.bofh.it> (permalink)
References	<pTkHh-7Tx-23@gated-at.bofh.it> <q23xv-310-11@gated-at.bofh.it> <q28GT-1SK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27 August 2015 at 18:50, Jason Low <jason.low2@hp.com> wrote:
> On Thu, 2015-08-27 at 13:21 +0200, Vincent Guittot wrote:
>> Hi,
>>
>> On 3 August 2015 at 11:55, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>> > Since commit d4573c3e1c99 ("sched: Improve load balancing in the presence
>> > of idle CPUs"), the ILB CPU starts with the idle load balancing of other
>> > idle CPUs and finishes with itself in order to speed up the spread of tasks
>> > in all idle CPUs.
>> >
>> > The this_rq->next_balance is still used in nohz_idle_balance as an
>> > intermediate step to gather the shortest next balance before updating
>> > nohz.next_balance. But the former has not been updated yet and is likely to
>> > be set with the current jiffies. As a result, the nohz.next_balance will be
>> > set with current jiffies instead of the real next balance date. This
>> > generates spurious kicks of nohz ilde balance.
>> >
>> > nohz_idle_balance must set the nohz.next_balance without taking into
>> > account this_rq->next_balance which is not updated yet. Then, this_rq will
>> > update nohz.next_update with its next_balance once updated and if necessary.
>> >
>> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
>
> Acked-by: Jason Low <jason.low2@hp.com>

Thanks

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] sched: fix nohz.next_balance update Vincent Guittot <vincent.guittot@linaro.org> - 2015-08-27 13:30 +0200
  Re: [PATCH v2] sched: fix nohz.next_balance update Jason Low <jason.low2@hp.com> - 2015-08-27 19:00 +0200
    Re: [PATCH v2] sched: fix nohz.next_balance update Vincent Guittot <vincent.guittot@linaro.org> - 2015-08-28 13:20 +0200

csiph-web