Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215113

Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch.

Show all headers | View raw

* Andrey Ryabinin <ryabinin.a.a@gmail.com> wrote:

> In not-instrumented code KASAN replaces instrumented
> memset/memcpy/memmove with not-instrumented analogues
> __memset/__memcpy/__memove.
> However, on x86 EFI stub is not linked with kernel.

s/with the kernel

> It uses not-instrumented mem*() functions from
> arch/x86/boot/compressed/string.c
> So we don't replace them with __mem*() variants in EFI stub.
> 
> In ARM64 EFI stub is linked with the kernel, so we should

s/In ARM64 EFI stub/On ARM64 the EFI stub/.

> replace mem*() functions with __mem*(), because EFI stub

s/the EFI stub

> runs before KASAN setup early shadow.

s/before KASAN sets up the early shadow

?

> So let's move these #undef mem* into arch's asm/efi.h which is

s/lets

> also included by EFI stub.

s/by the EFI stub

> 
> Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> ---
>  arch/x86/include/asm/efi.h             | 8 ++++++++
>  drivers/firmware/efi/libstub/efistub.h | 4 ----
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
> index 155162e..d821ce2 100644
> --- a/arch/x86/include/asm/efi.h
> +++ b/arch/x86/include/asm/efi.h
> @@ -25,6 +25,14 @@
>  #define EFI32_LOADER_SIGNATURE	"EL32"
>  #define EFI64_LOADER_SIGNATURE	"EL64"
>  
> +/*
> + * Use memcpy/memset from arch/x86/boot/compressed/string.c
> + * for EFI stub.
> + */
> +#undef memcpy
> +#undef memset
> +#undef memmove

This comment should also mention why it's done, not what is done.

Also:

    s/for EFI stub/for the EFI stub

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] KASAN/ARM64 EFI fixes Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-26 18:20 +0200
  [PATCH 4/4] libfdt, kasan: don't instrument libfdt. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-26 18:20 +0200
  [PATCH 2/4] efi/runtime-wrappers, kasan: don't sanitize runtime wrappers. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-26 18:20 +0200
  [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-26 18:20 +0200
    Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per  arch. Ingo Molnar <mingo@kernel.org> - 2015-08-28 08:30 +0200
      Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per  arch. Leif Lindholm <leif.lindholm@linaro.org> - 2015-08-28 10:40 +0200
        Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per  arch. Ingo Molnar <mingo@kernel.org> - 2015-08-28 12:00 +0200
      [PATCH v2] x86, efi, kasan: #undef memset/memcpy/memmove per arch. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-28 13:20 +0200
        Re: [PATCH v2] x86, efi, kasan: #undef memset/memcpy/memmove per  arch. Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-28 16:50 +0200
          Re: [PATCH v2] x86, efi, kasan: #undef memset/memcpy/memmove per arch. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-28 17:00 +0200
  [PATCH 3/4] arm64/efi-stub, kasan: don't instrument efi-stub. Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2015-08-26 18:20 +0200

csiph-web