Re: [PATCH v3] selftests/zram: Adding zram tests

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] selftests/zram: Adding zram tests
Date	Fri, 28 Aug 2015 00:20:02 +0200
Message-ID	<q2dGy-Mo-33@gated-at.bofh.it> (permalink)
References	<pYJbY-7oT-37@gated-at.bofh.it> <q29Wh-3Qj-11@gated-at.bofh.it>
X-Original-To	naresh.kamboju@linaro.org, linux-kernel@vger.kernel.org
X-Enigmail-Draft-Status	N1110
Organization	Samsung Open Source Group
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
X-Original-Cc	tyler.baker@linaro.org, milosz.wasilewski@linaro.org, alexey.kodanev@oracle.com, Shuah Khan <shuahkh@osg.samsung.com>
X-Original-Date	Thu, 27 Aug 2015 16:12:07 -0600
X-Original-Message-ID	<55DF8B37.4060508@osg.samsung.com>
X-Original-References	<1439881319-9727-1-git-send-email-naresh.kamboju@linaro.org> <55DF5288.4040405@osg.samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1214853

Show key headers only | View raw

On 08/27/2015 12:10 PM, Shuah Khan wrote:
> On 08/18/2015 01:01 AM, naresh.kamboju@linaro.org wrote:
>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>
>> zram: Compressed RAM based block devices
>> ----------------------------------------
>> The zram module creates RAM based block devices named /dev/zram<id>
>> (<id> = 0, 1, ...). Pages written to these disks are compressed and stored
>> in memory itself. These disks allow very fast I/O and compression provides
>> good amounts of memory savings. Some of the usecases include /tmp storage,
>> use as swap disks, various caches under /var and maybe many more :)
>>
>> Statistics for individual zram devices are exported through sysfs nodes at
>> /sys/block/zram<id>/
>>
>> This patch is to validate the zram functionality. Test interacts with block
>> device /dev/zram<id> and sysfs nodes /sys/block/zram<id>/
>>
> 
> Hi Naresh,
> 
> This doesn't fail gracefully when a regular user runs it. Please add
> a check for root and make the test fail gracefully when a non-root
> user runs it.
> 
> Please refer to tools/testing/selftests/efivarfs/efivarfs.sh
> for an example on how to check for root.
> 
> I was getting ready to apply this to linux-kselftest next for 4.3
> and ran some sanity tests. If you get me new revision quickly
> I can get it into 4.3-rc1.

Hi Naresh,

The patch is now in linux-kselftest next. Please send a fix in for
the non-root case for me get it into 4.3-rc1 or rc2.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v3] selftests/zram: Adding zram tests Shuah Khan <shuahkh@osg.samsung.com> - 2015-08-27 20:20 +0200
  Re: [PATCH v3] selftests/zram: Adding zram tests Shuah Khan <shuahkh@osg.samsung.com> - 2015-08-28 00:20 +0200
    Re: [PATCH v3] selftests/zram: Adding zram tests Naresh Kamboju <naresh.kamboju@linaro.org> - 2015-08-31 13:50 +0200

csiph-web