Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214778

Re: [PATCH] soc: ti: reset irq affinity before freeing irq

Show all headers | View raw

On 8/27/15 11:34 AM, Nathan Lynch wrote:
> On 08/27/2015 01:23 PM, Murali Karicheri wrote:
>> On 08/27/2015 12:43 PM, Nathan Lynch wrote:
>>> On 08/27/2015 10:51 AM, Murali Karicheri wrote:
>>>> When using accumulator queue for rx side for network driver, following
>>>> warning is seen when doing a reboot command from Linux console. This
>>>> is because, affinity value is not reset before calling free_irq(). This
>>>> patch fixes this.
>>>>
>>>> Deconfiguring network interfaces...
>>>> [   55.176589] ------------[ cut here ]-----------
>>>> [   55.181232] WARNING: CPU: 0 PID: 2081 at kernel/irq/manage.c:1370
>>>> __free_irq+0x208/0x214
>>>
>>> The full content of the warning should be included in the commit
>>> message; __free_irq has several potential sources of warning messages,
>>> and line 1370 doesn't correspond to any of them in 4.2-rc8.
>>
>> The log corresponds to 4.1.x kernel. Corresponding WARN_ONCE is
>>
>> #ifdef CONFIG_SMP
>>          /* make sure affinity_hint is cleaned up */
>>          if (WARN_ON_ONCE(desc->affinity_hint))
>>                  desc->affinity_hint = NULL;
>> #endif
>>
>> Which is line 1922. I can edit to make it 1922. Does that work?
>
> Eh, I guess I wasn't thinking clearly about this clearly when I wrote
> that.  (I somehow had the notion that WARN_ON... maybe printed more than
> just the file and line number, but that is clearly mistaken.)  I think
> your message is fine as is, sorry for the noise.
>
> I don't think changing the line number will make it any easier on future
> readers.
>
Right. Just leave the full call in the commit so that the context
is captured.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] soc: ti: reset irq affinity before freeing irq Murali Karicheri <m-karicheri2@ti.com> - 2015-08-27 18:00 +0200
  Re: [PATCH] soc: ti: reset irq affinity before freeing irq "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-08-27 18:50 +0200
  Re: [PATCH] soc: ti: reset irq affinity before freeing irq Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-08-27 18:50 +0200
    Re: [PATCH] soc: ti: reset irq affinity before freeing irq Murali Karicheri <m-karicheri2@ti.com> - 2015-08-27 20:30 +0200
      Re: [PATCH] soc: ti: reset irq affinity before freeing irq "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-08-27 20:40 +0200
        Re: [PATCH] soc: ti: reset irq affinity before freeing irq Murali Karicheri <m-karicheri2@ti.com> - 2015-08-27 23:50 +0200
      Re: [PATCH] soc: ti: reset irq affinity before freeing irq Nathan Lynch <Nathan_Lynch@mentor.com> - 2015-08-27 20:40 +0200

csiph-web