Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1215857
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 8/8] staging: lustre: put constant on the right of binary operator |
| Date | 2015-08-30 02:00 +0200 |
| Message-ID | <q2Ycq-kl-7@gated-at.bofh.it> (permalink) |
| References | <q2Sql-ob-3@gated-at.bofh.it> <q2Sql-ob-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 2015-08-29 at 19:30 +0200, Julia Lawall wrote: > Move constants to the right of binary operators. [] > diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c [] > @@ -2954,7 +2954,7 @@ void ptlrpc_init_xid(void) > } > > /* Always need to be aligned to a power-of-two for multi-bulk BRW */ > - CLASSERT((PTLRPC_BULK_OPS_COUNT & (PTLRPC_BULK_OPS_COUNT - 1)) == 0); > + CLASSERT(((PTLRPC_BULK_OPS_COUNT - 1) & PTLRPC_BULK_OPS_COUNT) == 0); This one would probably be better as CLASSERT(is_power_of_2(PTLRPC_BULK_OPS_COUNT)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 7/8] staging: lustre: osc: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 1/8] staging: lustre: include: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 8/8] staging: lustre: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
Re: [PATCH 8/8] staging: lustre: put constant on the right of binary operator Joe Perches <joe@perches.com> - 2015-08-30 02:00 +0200
Re: [PATCH 8/8] staging: lustre: put constant on the right of binary operator Julia Lawall <julia.lawall@lip6.fr> - 2015-08-30 10:50 +0200
Re: [PATCH 8/8] staging: lustre: put constant on the right of binary operator Julia Lawall <julia.lawall@lip6.fr> - 2015-08-30 19:20 +0200
[PATCH 6/8] Staging: lustre: obd: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 3/8] staging: lustre: ldlm: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 2/8] staging: lustre: lnet: lib-ptl.c: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 5/8] staging: lustre: llite: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
[PATCH 4/8] staging: lustre: libcfs: put constant on the right of binary operator Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-29 19:50 +0200
csiph-web