Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions
Date	2015-08-29 12:30 +0200
Message-ID	<q2Lyy-7rp-19@gated-at.bofh.it> (permalink)
References	<q1Jfs-7l6-5@gated-at.bofh.it> <q1Jfs-7l6-13@gated-at.bofh.it> <q2e9z-1mE-7@gated-at.bofh.it> <q2uHp-7g-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 28, 2015 at 01:27:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 27, 2015 at 11:47:19PM +0100, Matt Fleming escreveu:
> > On Wed, 26 Aug, at 03:46:44PM, Jiri Olsa wrote:
> > > There's no need for find_tracing_dir, because perf already
> > > searches for debugfs/tracefs mount on start and populate
> > > tracing_events_path.
> >  
> > I'm getting a bit lost searching through the git history of these
> > functions. Why is it safe to delete these functions? Where did the old
> > user that required find_tracing_dir() to mount debugfs disappear to?
> > 
> > The code to do the mount of debugfs/tracefs when perf starts appears
> > to have been around for years. Is the mounting operation of
> > find_tracing_dir() just dead code?

yep, I'll address that in v2.. found TODO in fs.c ;-)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 02/11] perf tools: Add tracing_path and remove unneeded functions Jiri Olsa <jolsa@kernel.org> - 2015-08-26 15:50 +0200
  Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded  functions Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-28 00:50 +0200
    Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded  functions Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-28 18:30 +0200
      Re: [PATCH 02/11] perf tools: Add tracing_path and remove unneeded  functions Jiri Olsa <jolsa@redhat.com> - 2015-08-29 12:30 +0200
  [tip:perf/core] perf tools:   Add tracing_path and remove unneeded functions tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-08-31 10:40 +0200

csiph-web