Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215655

Re: [PATCHv6 net-next 00/10] OVS conntrack support

Show all headers | View raw

On 28 August 2015 at 16:57, Simon Horman <simon.horman@netronome.com> wrote:
> On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote:
>> The goal of this series is to allow OVS to send packets through the Linux
>> kernel connection tracker, and subsequently match on fields populated by
>> conntrack. This functionality is enabled through a new
>> CONFIG_OPENVSWITCH_CONNTRACK option.
>>
>> This version addresses the feedback from v5, primarily checking the behaviour
>> is correct with different configurations such as disabling
>> CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like
>> connlabels.
>>
>> The branch below has been updated with the corresponding userspace pieces:
>> https://github.com/joestringer/ovs dev/ct_20150818
>
> Hi Joe,
>
> Nice work getting this patchset in order.
>
> I am seeing the following when compiling without NF_CONNTRACK_MARK set.
>
>   CC [M]  net/openvswitch//conntrack.o
> net/openvswitch//conntrack.c: In function ‘__ovs_ct_update_key’:
> net/openvswitch//conntrack.c:127:24: error: ‘const struct nf_conn’ has no member named ‘mark’
>   key->ct.mark = ct ? ct->mark : 0;
>                         ^
> net/openvswitch//conntrack.c: In function ‘ovs_ct_set_mark’:
> net/openvswitch//conntrack.c:195:26: error: ‘struct nf_conn’ has no member named ‘mark’
>   new_mark = ct_mark | (ct->mark & ~(mask));
>                           ^
> net/openvswitch//conntrack.c:196:8: error: ‘struct nf_conn’ has no member named ‘mark’
>   if (ct->mark != new_mark) {
>         ^
> net/openvswitch//conntrack.c:197:5: error: ‘struct nf_conn’ has no member named ‘mark’
>    ct->mark = new_mark;
>      ^
> scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o' failed
> make[1]: *** [net/openvswitch//conntrack.o] Error 1
> Makefile:1386: recipe for target '_module_net/openvswitch/' failed
> make: *** [_module_net/openvswitch/] Error 2

Thanks for reporting this, I sent a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv6 net-next 00/10] OVS conntrack support Joe Stringer <joestringer@nicira.com> - 2015-08-26 20:40 +0200
  [PATCHv6 net-next 08/10] netfilter: connlabels: Export setting connlabel length Joe Stringer <joestringer@nicira.com> - 2015-08-26 20:40 +0200
  [PATCHv6 net-next 06/10] openvswitch: Allow matching on conntrack mark Joe Stringer <joestringer@nicira.com> - 2015-08-26 20:40 +0200
  [PATCHv6 net-next 01/10] openvswitch: Serialize acts with original netlink len Joe Stringer <joestringer@nicira.com> - 2015-08-26 20:40 +0200
  Re: [PATCHv6 net-next 05/10] openvswitch: Add conntrack action Joe Stringer <joestringer@nicira.com> - 2015-08-26 21:00 +0200
  Re: [PATCHv6 net-next 05/10] openvswitch: Add conntrack action Pravin Shelar <pshelar@nicira.com> - 2015-08-26 22:50 +0200
  Re: [PATCHv6 net-next 00/10] OVS conntrack support David Miller <davem@davemloft.net> - 2015-08-27 20:50 +0200
  Re: [PATCHv6 net-next 00/10] OVS conntrack support Simon Horman <simon.horman@netronome.com> - 2015-08-29 02:00 +0200
    Re: [PATCHv6 net-next 00/10] OVS conntrack support Joe Stringer <joestringer@nicira.com> - 2015-08-29 04:30 +0200

csiph-web