Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214769

[PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

b9d5c6b7ef57 ("[SCSI] cleanup setting task state in
scsi_error_handler()") has introduced a race between scsi_error_handler
and scsi_host_dev_release resulting in the hang when the device goes
away because scsi_error_handler might miss a wake up:

CPU0					CPU1
scsi_error_handler			scsi_host_dev_release
  					  kthread_stop()
  kthread_should_stop()
    test_bit(KTHREAD_SHOULD_STOP)
					    set_bit(KTHREAD_SHOULD_STOP)
					    wake_up_process()
					    wait_for_completion()

  set_current_state(TASK_INTERRUPTIBLE)
  schedule()

The most straightforward solution seems to be to invert the ordering of
the set_current_state and kthread_should_stop.

The issue has been noticed during reboot test on a 3.0 based kernel but
the current code seems to be affected in the same way.

Cc: stable # 3.6+
Reported-and-Debugged-by: Mike Mayer <Mike.Meyer@teradata.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 drivers/scsi/scsi_error.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 6457a8a0db9c..2c0a817d5dbe 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -2169,8 +2169,11 @@ int scsi_error_handler(void *data)
 	 * We never actually get interrupted because kthread_run
 	 * disables signal delivery for the created thread.
 	 */
-	while (!kthread_should_stop()) {
+	while (true) {
 		set_current_state(TASK_INTERRUPTIBLE);
+		if (kthread_should_stop())
+			break;
+
 		if ((shost->host_failed == 0 && shost->host_eh_scheduled == 0) ||
 		    shost->host_failed != atomic_read(&shost->host_busy)) {
 			SCSI_LOG_ERROR_RECOVERY(1,
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race mhocko@kernel.org - 2015-08-27 20:20 +0200
  Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race Dan Williams <dan.j.williams@intel.com> - 2015-08-27 20:30 +0200
  Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release  race Hannes Reinecke <hare@suse.de> - 2015-08-28 08:50 +0200
  Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release  race James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-08-28 17:00 +0200
    Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release  race Michal Hocko <mhocko@kernel.org> - 2015-08-28 17:20 +0200

csiph-web