[PATCH 2/2] perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems

X-FeedAbuse	http://nntpfeed.proxad.net/abuse.pl feeded by 78.192.65.63
Path	csiph.com!goblin2!goblin1!goblin.stu.neva.ru!proxad.net!feeder1-2.proxad.net!nntpfeed.proxad.net!news.muarf.org!news.ecp.fr!aioe.org!bofh.it!news.nic.it!robomod
From	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems
Date	Thu, 27 Aug 2015 17:20:01 +0200
Message-ID	<q2785-8ds-9@gated-at.bofh.it> (permalink)
References	<q2785-8ds-11@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <a.p.zijlstra@chello.nl>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.17,422,1437462000"; d="scan'208";a="756563361"
X-Mailer	git-send-email 2.5.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo <acme@infradead.org>, Alexander Shishkin <alexander.shishkin@linux.intel.com>
X-Original-Date	Thu, 27 Aug 2015 18:13:42 +0300
X-Original-Message-ID	<1440688422-27954-3-git-send-email-alexander.shishkin@linux.intel.com>
X-Original-References	<1440688422-27954-1-git-send-email-alexander.shishkin@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1214638

Show key headers only | View raw

BTS leaks kernel addresses even in userspace-only mode due to imprecise IP
sampling, so sometimes syscall entry points or page fault handler addresses
end up in a userspace trace.

Now, intel_bts driver exports trace data zero-copy, it does not scan through
it to filter out the kernel addresses and it's would be a O(n) job.

To work around this situation, this patch forbids the use of intel_bts
driver by unprivileged users with paranoid setting higher than 1, which
forbids kernel tracing.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 arch/x86/kernel/cpu/perf_event_intel_bts.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_bts.c b/arch/x86/kernel/cpu/perf_event_intel_bts.c
index 80df16e020..4f6daff92d 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_bts.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_bts.c
@@ -495,6 +495,16 @@ static int bts_event_init(struct perf_event *event)
 	if (x86_add_exclusive(x86_lbr_exclusive_bts))
 		return -EBUSY;
 
+	/*
+	 * BTS leaks kernel addresses even when CPL0 tracing is
+	 * disabled, so disallow intel_bts driver for unprivileged
+	 * users on paranoid systems since it provides trace data
+	 * to the user in a zero-copy fashion.
+	 */
+	if (event->attr.exclude_kernel && perf_paranoid_kernel() &&
+	    !capable(CAP_SYS_ADMIN))
+		return -EACCES;
+
 	ret = x86_reserve_hardware();
 	if (ret) {
 		x86_del_exclusive(x86_lbr_exclusive_bts);
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-27 17:20 +0200
  Re: [PATCH 2/2] perf/x86/intel/bts: Disallow use by unprivileged  users on paranoid systems Ingo Molnar <mingo@kernel.org> - 2015-08-28 07:40 +0200
    Re: [PATCH 2/2] perf/x86/intel/bts: Disallow use by unprivileged users on paranoid systems Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-08-28 11:50 +0200

csiph-web