Re: [RFC 2/3] firmware_class: split out transaction helpers

From	Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups	linux.kernel
Subject	Re: [RFC 2/3] firmware_class: split out transaction helpers
Date	2015-08-27 16:50 +0200
Message-ID	<q26F4-7pQ-5@gated-at.bofh.it> (permalink)
References	<pkJh8-2fa-15@gated-at.bofh.it> <pkJqN-2qL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 29 Apr, at 04:10:52PM, James Bottomley wrote:
> From: James Bottomley <JBottomley@Odin.com>
> 
> The firmware class contains code to manage an arbitrary sized buffer for
> discrete read and write operations.  We need precisely this ability to update
> firmware capsule files (and likely for other transactions as well), so split
> out the capability into a library helper
> 
> Signed-off-by: James Bottomley <JBottomley@Odin.com>
> ---
>  drivers/base/firmware_class.c      | 117 ++++---------------------------
>  include/linux/transaction_helper.h |  26 +++++++
>  lib/Makefile                       |   2 +-
>  lib/transaction_helper.c           | 137 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 179 insertions(+), 103 deletions(-)
>  create mode 100644 include/linux/transaction_helper.h
>  create mode 100644 lib/transaction_helper.c

(Sorry, I'm coming to this incredibly late)

This patch is pretty neat and I wish something like this had existed
when I originally wrote the EFI capsule patches.

James, do you have any plans to resubmit this as a non-RFC? If not, do
you mind if I pick this up and rebase my capsule patches ontop of it?

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC 2/3] firmware_class: split out transaction helpers Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-27 16:50 +0200
  Re: [RFC 2/3] firmware_class: split out transaction helpers James Bottomley <James.Bottomley@HansenPartnership.com> - 2015-08-27 18:30 +0200
    Re: [RFC 2/3] firmware_class: split out transaction helpers Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-27 21:50 +0200

csiph-web