Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214572

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

Show all headers | View raw

On 25 August 2015 at 14:06, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 14 August 2015 at 09:30,  <sdliyong@gmail.com> wrote:
>> From: Yong Li <sdliyong@gmail.com>
>>
>> Signed-off-by: Yong Li <sdliyong@gmail.com>
>> ---
>>  drivers/mmc/card/block.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
>> index 452782b..d9e3c45 100644
>> --- a/drivers/mmc/card/block.c
>> +++ b/drivers/mmc/card/block.c
>> @@ -1366,7 +1366,8 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
>>         bool do_rel_wr = ((req->cmd_flags & REQ_FUA) ||
>>                           (req->cmd_flags & REQ_META)) &&
>>                 (rq_data_dir(req) == WRITE) &&
>> -               (md->flags & MMC_BLK_REL_WR);
>> +               (md->flags & MMC_BLK_REL_WR) &&
>> +               !(card->quirks & MMC_QUIRK_BLK_NO_CMD23);
>
> Further down in mmc_blk_rw_rq_prep() we check for
> MMC_QUIRK_BLK_NO_CMD23. That check becomes redundant after this
> change, please remove that check as a part of this patch as well.
>
>>
>>         memset(brq, 0, sizeof(struct mmc_blk_request));
>>         brq->mrq.cmd = &brq->cmd;
>> --
>> 2.1.0
>>
>

Please ignore my previous answer. MMC_QUIRK_BLK_NO_CMD23 is intended
to indicate to the mmc block layer whether using CMD23 for regular
block IO request could have a performance impact for some cards. If
that's the case we don't use it - except when using reliable write!

So this patch is just plain wrong.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-25 14:10 +0200
  RE: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 LIYONG <sdliyong@gmail.com> - 2015-08-26 08:20 +0200
    Re: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 Shawn Lin <shawn.lin@rock-chips.com> - 2015-08-26 09:30 +0200
      RE: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 LIYONG <sdliyong@gmail.com> - 2015-08-26 14:40 +0200
  Re: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-27 15:30 +0200
    RE: [PATCH] mmc: block: disable the reliable write If the card does  not support CMD23 LIYONG <sdliyong@gmail.com> - 2015-08-28 02:40 +0200

csiph-web