Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213477

Re: [PATCH 1/3] ARM: uniphier: add outer cache support

Show all headers | View raw

Hi Arnd,


2015-08-25 4:59 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Monday 24 August 2015 11:18:10 Masahiro Yamada wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/uniphier/cache-uniphier.txt b/Documentation/devicetree/bindings/arm/uniphier/cache-uniphier.txt
>> new file mode 100644
>> index 0000000..6428289
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/uniphier/cache-uniphier.txt
>> @@ -0,0 +1,30 @@
>> +UniPhier outer cache controller
>> +
>> +UniPhier SoCs are integrated with a level 2 cache controller that resides
>> +outside of the ARM cores, some of them also have a level 3 cache controller.
>> +
>> +Required properties:
>> +- compatible: should be one of the followings:
>> +       "socionext,uniphier-l2-cache"   (L2 cache)
>> +       "socionext,uniphier-l3-cache"   (L3 cache)
>> +- reg: offsets and lengths of the register sets for the device.  It should
>> +  contain 3 regions: control registers, revision registers, operation
>> +  registers, in this order.
>> +
>> +The L2 cache must exist to use the L3 cache; adding only an L3 cache device
>> +node to the device tree causes the initialization failure of the whole outer
>> +cache system.
>>
>
> How much does this outer cache have in common with the l2x0/pl310 cache
> controller model?

Nothing.

This outer cache is not a variant of l2x0/pl310.
It was designed only for our SoCs from scratch.


> Would it make sense to at least share the
> common entry point at l2x0_of_init() so you don't need to call it from
> the platform file?

I do not think so.


l2x0_of_init() checks L2X0_AUX_CTRL register,
but the cache-uniphier does not have such register,
so the boot code crashes.



BTW, what makes l2x0_of_init() so special?

Only L2x0/L310 and variants can be initialized
directly from init_IRQ().

Moreover, outer-cache init seems to be unrelated to
IRQ init.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-24 04:30 +0200
  [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-24 04:30 +0200
    Re: [PATCH 1/3] ARM: uniphier: add outer cache support Joe Perches <joe@perches.com> - 2015-08-24 04:30 +0200
      Re: [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-24 05:00 +0200
    Re: [PATCH 1/3] ARM: uniphier: add outer cache support Arnd Bergmann <arnd@arndb.de> - 2015-08-24 22:10 +0200
      Re: [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-26 03:40 +0200
        Re: [PATCH 1/3] ARM: uniphier: add outer cache support Arnd Bergmann <arnd@arndb.de> - 2015-08-26 15:00 +0200
          Re: [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-28 11:10 +0200
          Re: [PATCH 1/3] ARM: uniphier: add outer cache support Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-28 11:50 +0200
    Re: [PATCH 1/3] ARM: uniphier: add outer cache support Linus Walleij <linus.walleij@linaro.org> - 2015-08-26 15:40 +0200
      Re: [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-28 12:30 +0200
  [PATCH 2/3] ARM: uniphier: rework SMP operations to use trampoline code Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-24 04:30 +0200
  Re: [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Olof Johansson <olof@lixom.net> - 2015-08-24 23:50 +0200
    Re: [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-08-25 04:00 +0200
      Re: [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Olof Johansson <olof@lixom.net> - 2015-08-25 05:10 +0200
        Re: [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-25 05:20 +0200

csiph-web