Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213419

Re: [PATCH V3] regulator: core: Define regulator_set_voltage_triplet()

Show all headers | View raw

On 08/17, Viresh Kumar wrote:
> Voltage tolerance isn't necessarily same on both sides of the target
> voltage and regulator_set_voltage_tol() wouldn't be suitable in such
> cases.
> 
> Add another routine regulator_set_voltage_triplet(), which accepts
> target, min and max voltages as arguments.
> 
> This first tries to set the voltage between the target voltage and the
> upper limit, then fall back on the full range. The idea behind this is
> to set regulator's voltage as close to the target voltage, as possible.
> 
> Based on regulator_set_voltage_tol().
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Looks good to me.

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V3] regulator: core: Define  regulator_set_voltage_triplet() Stephen Boyd <sboyd@codeaurora.org> - 2015-08-26 01:00 +0200

csiph-web