Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213365

Re: [PATCH v2] mmc: host: use of_property_read_bool()

Show all headers | View raw

On 25 August 2015 at 18:32, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 08/25/2015 03:05 PM, Ulf Hansson wrote:
>
>>> Use more compact of_property_read_bool() calls instead of the
>>> of_find_property()
>>> calls.
>
>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
>
>> Thanks, applied for next!
>
>
>    Thanks to you! :-)
>
>> Next, time please run checkpatch to remove errors/warnings.
>
>
>    Hum, I just did and the patch seems clean:
>
> [headless@wasted mmc]$ scripts/checkpatch.pl
> patches/mmc-host-use-of_property_read_bool.patch
> total: 0 errors, 0 warnings, 81 lines checked
>
> patches/mmc-host-use-of_property_read_bool.patch has no obvious style
> problems and is ready for submission.
>
>    What do you mean?

WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#12:
Use more compact of_property_read_bool() calls instead of the of_find_property()

total: 0 errors, 1 warnings, 81 lines checked

I suspect we might use different versions of the checkpatch script.
Mine is from 4.2rc7.

No worries then!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mmc: host: use of_property_read_bool() Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-25 14:10 +0200
  Re: [PATCH v2] mmc: host: use of_property_read_bool() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-25 18:40 +0200
    Re: [PATCH v2] mmc: host: use of_property_read_bool() Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-25 23:20 +0200
      Re: [PATCH v2] mmc: host: use of_property_read_bool() Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-26 00:00 +0200

csiph-web