Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1213217
| From | Mark Salter <msalter@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) |
| Date | 2015-08-25 20:20 +0200 |
| Message-ID | <q1qZc-5WK-7@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <q1noB-D2-7@gated-at.bofh.it> <q1o1j-1BK-1@gated-at.bofh.it> <q1pJL-3ZR-11@gated-at.bofh.it> <q1qmt-4Ya-3@gated-at.bofh.it> <q1qPw-5Lv-33@gated-at.bofh.it> |
| Organization | Red Hat, Inc |
On Tue, 2015-08-25 at 20:02 +0200, Oleg Nesterov wrote:
> On 08/25, Oleg Nesterov wrote:
> >
> > On 08/26, Yoshinori Sato wrote:
> > >
> > > Yes.
> > > gcc bug #67055.
> > > Already fixed in trunk.
> >
> > Yes, thanks a lot.
> >
> > Paul, it seems that gcc actually dislikes your ec90a194a "rcu:
> > Create a synchronize_rcu_mult()" commit ;) rcu/sync.c was just
> > lucky enough to trigger the problem.
> >
> > I'll try to make the fix today...
>
> Mark, Guenter, any chance you can check if the patch below helps?
> It does on x86.
Works for c6x.
>
> Oleg.
>
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -230,12 +230,11 @@ void __wait_rcu_gp(bool checktiny, int n,
> call_rcu_func_t *crcu_array,
> struct rcu_synchronize *rs_array);
>
> #define _wait_rcu_gp(checktiny, ...) \
> -do { \
> - call_rcu_func_t __crcu_array[] = { __VA_ARGS__ }; \
> - const int __n = ARRAY_SIZE(__crcu_array); \
> - struct rcu_synchronize __rs_array[__n]; \
> - \
> - __wait_rcu_gp(checktiny, __n, __crcu_array, __rs_array); \
> +do {
> \
> + call_rcu_func_t __crcu_array[] = { __VA_ARGS__ };
> \
> + struct rcu_synchronize __rs_array[ARRAY_SIZE(__crcu_array)];
> \
> + __wait_rcu_gp(checktiny, ARRAY_SIZE(__crcu_array),
> \
> + __crcu_array, __rs_array);
> \
> } while (0)
>
> #define wait_rcu_gp(...) _wait_rcu_gp(false, __VA_ARGS__)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
h8300 build failures ijn linux-next Guenter Roeck <linux@roeck-us.net> - 2015-08-24 20:40 +0200
Re: h8300 build failures ijn linux-next Yoshinori Sato <ysato@users.sourceforge.jp> - 2015-08-25 08:00 +0200
Re: h8300 build failures ijn linux-next Mark Salter <msalter@redhat.com> - 2015-08-25 16:30 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Guenter Roeck <linux@roeck-us.net> - 2015-08-25 17:10 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Oleg Nesterov <oleg@redhat.com> - 2015-08-25 18:20 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Oleg Nesterov <oleg@redhat.com> - 2015-08-25 18:30 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Yoshinori Sato <ysato@users.sourceforge.jp> - 2015-08-25 19:00 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Oleg Nesterov <oleg@redhat.com> - 2015-08-25 19:40 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Oleg Nesterov <oleg@redhat.com> - 2015-08-25 20:10 +0200
Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Mark Salter <msalter@redhat.com> - 2015-08-25 20:20 +0200
[PATCH] rcu: change _wait_rcu_gp() to work around gcc 67055 bug Oleg Nesterov <oleg@redhat.com> - 2015-08-25 20:50 +0200
Re: [PATCH] rcu: change _wait_rcu_gp() to work around gcc 67055 bug "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-08-25 21:10 +0200
Re: [PATCH] rcu: change _wait_rcu_gp() to work around gcc 67055 bug Oleg Nesterov <oleg@redhat.com> - 2015-08-25 21:10 +0200
csiph-web