Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1213162
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information |
| Date | 2015-08-25 18:30 +0200 |
| Message-ID | <q1pgL-3rY-29@gated-at.bofh.it> (permalink) |
| References | <q1g3L-6Xi-3@gated-at.bofh.it> <q1g3M-6Xi-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, Aug 25, 2015 at 08:31:17AM +0200, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c:<modalias>" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (i.e: I2C id table or OF match table). > > So drivers needs to export the I2C id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > But this means that OF-only drivers needs to have both OF and I2C id > tables that have to be kept in sync and also the dev node compatible > manufacturer prefix is stripped when reporting the MODALIAS. Which can > lead to issues if two vendors use the same I2C device name for example. > > To avoid the above, the I2C core behavior may be changed in the future > to not require an SPI device table for OF-only drivers and report the > OF module alias. So, it's better to also export the OF table even when > is unused now to prevent breaking module loading when the core changes. So, on the one hand detailed commit messages are nice. On the other hand if they wander too far off point it can be hard to sustain interest and one can glaze over a bit. All the above really needs to say is that if we want to use the OF alias table we need to export it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND PATCH 0/7] Export I2C and OF module aliases in missing drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
[RESEND PATCH 6/7] leds: Export OF module alias information in missing drivers Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 6/7] leds: Export OF module alias information in missing drivers Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-08-25 11:20 +0200
[RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Lee Jones <lee.jones@linaro.org> - 2015-08-25 09:40 +0200
[RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Wolfram Sang <wsa@the-dreams.de> - 2015-08-26 19:00 +0200
Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-26 20:20 +0200
Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Wolfram Sang <wsa@the-dreams.de> - 2015-08-31 22:40 +0200
Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-01 00:40 +0200
Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Wolfram Sang <wsa@the-dreams.de> - 2015-09-01 00:50 +0200
[RESEND PATCH 3/7] usb: phy: isp1301: Export I2C module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 3/7] usb: phy: isp1301: Export I2C module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-01 17:30 +0200
[RESEND PATCH 4/7] ALSA: ppc: keywest: Export I2C module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 4/7] ALSA: ppc: keywest: Export I2C module alias information Takashi Iwai <tiwai@suse.de> - 2015-08-25 12:30 +0200
[RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 08:40 +0200
Re: [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Mark Brown <broonie@kernel.org> - 2015-08-25 18:30 +0200
Re: [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-25 19:40 +0200
Re: [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Mark Brown <broonie@kernel.org> - 2015-08-25 20:10 +0200
csiph-web