Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular

From	Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular
Date	2015-08-25 17:40 +0200
Message-ID	<q1oun-2cl-61@gated-at.bofh.it> (permalink)
References	<q18fU-4hZ-5@gated-at.bofh.it> <q18fU-4hZ-17@gated-at.bofh.it> <q1nRF-1aY-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-08-25 10:59 AM, Christoph Lameter wrote:
> On Mon, 24 Aug 2015, Paul Gortmaker wrote:
> 
>> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void)
>>  						&proc_slabinfo_operations);
>>  	return 0;
>>  }
>> -module_init(slab_proc_init);
>> +device_initcall(slab_proc_init);
>>  #endif /* CONFIG_SLABINFO */
>>
>>  static __always_inline void *__do_krealloc(const void *p, size_t new_size,
> 
> True memory management is not a module. But its also not a device.

Per the 0/N I'd rather make it equivalent to what it was already
at this point in time and then consider making it a core_initcall
or post_core early in the next dev cycle if we want to give it
a more appropriately matching category, so we can then watch for
init reordering fallout with more time on our hands.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/10] mm: make slab_common.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-25 00:20 +0200
  Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular Christoph Lameter <cl@linux.com> - 2015-08-25 17:00 +0200
    Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-08-25 17:40 +0200

csiph-web