Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1213083
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info |
| Date | 2015-08-25 16:30 +0200 |
| Message-ID | <q1noC-D2-33@gated-at.bofh.it> (permalink) |
| References | <q0UPE-1qY-3@gated-at.bofh.it> <q0ZvY-8a9-1@gated-at.bofh.it> <q1jbk-2TE-15@gated-at.bofh.it> |
| Organization | D03 |
On Tue, Aug 25 2015, Ingo Molnar <mingo@kernel.org> wrote:
> * George Spelvin <linux@horizon.com> wrote:
>
>> (I hope I'm not annoying you by bikeshedding this too much, although I
>> think this is improving.)
>
> [ I don't mind, although I wish other, more critical parts of the kernel got this
> much attention as well ;-) ]
>
Since we're beating dead horses, let me point out one possibly
unintentional side-effect of initializing just one of vmap_info{,_cache}_gen:
$ nm -n vmlinux | grep -E 'vmap_info(_cache)?_gen'
ffffffff81e4e5e0 d vmap_info_gen
ffffffff820d5700 b vmap_info_cache_gen
[Up-thread, you wrote "I also moved the function-static cache next to the
flag and seqlock - this should further compress the cache footprint."]
One should probably ensure that they end up in the same cacheline if one
wants the fast-path to be as fast as possible - the easiest way to
ensure that is to put them in a small struct, and that might as well
contain the spinlock and the cache itself as well.
It's been fun seeing this evolve, but overall, I tend to agree with
Peter: It's a lot of complexity for little gain. If we're not going to
just kill the Vmalloc* fields (which is probably too controversial)
I'd prefer Linus' simpler version.
Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics "George Spelvin" <linux@horizon.com> - 2015-08-23 06:50 +0200
Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics Ingo Molnar <mingo@kernel.org> - 2015-08-23 08:10 +0200
Re: [PATCH 0/3] mm/vmalloc: Cache the /proc/meminfo vmalloc statistics "George Spelvin" <linux@horizon.com> - 2015-08-23 08:50 +0200
[PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-23 10:20 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-08-23 23:00 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-24 09:00 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-08-24 10:40 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-08-24 00:00 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-24 09:10 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-25 18:40 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-25 19:10 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info "George Spelvin" <linux@horizon.com> - 2015-08-24 03:10 +0200
[PATCH 3/3 v4] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-24 09:40 +0200
Re: [PATCH 3/3 v4] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-24 09:50 +0200
[PATCH 3/3 v5] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-24 10:00 +0200
Re: [PATCH 3/3 v5] mm/vmalloc: Cache the vmalloc memory info "George Spelvin" <linux@horizon.com> - 2015-08-24 15:00 +0200
[PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info Ingo Molnar <mingo@kernel.org> - 2015-08-25 12:00 +0200
Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info "George Spelvin" <linux@horizon.com> - 2015-08-25 12:40 +0200
Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info Peter Zijlstra <peterz@infradead.org> - 2015-08-25 15:10 +0200
Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-08-25 16:30 +0200
Re: [PATCH 3/3 v6] mm/vmalloc: Cache the vmalloc memory info "George Spelvin" <linux@horizon.com> - 2015-08-25 17:20 +0200
Re: [PATCH 3/3 v4] mm/vmalloc: Cache the vmalloc memory info "John Stoffel" <john@stoffel.org> - 2015-08-24 15:50 +0200
Re: [PATCH 3/3 v4] mm/vmalloc: Cache the vmalloc memory info "George Spelvin" <linux@horizon.com> - 2015-08-24 17:20 +0200
Re: [PATCH 3/3 v4] mm/vmalloc: Cache the vmalloc memory info "John Stoffel" <john@stoffel.org> - 2015-08-24 18:00 +0200
Re: [PATCH 3/3 v3] mm/vmalloc: Cache the vmalloc memory info Peter Zijlstra <peterz@infradead.org> - 2015-08-25 14:50 +0200
csiph-web