Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI
Date	2015-08-25 14:10 +0200
Message-ID	<q1ld8-60p-9@gated-at.bofh.it> (permalink)
References	<pUm4h-7Vg-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 6 August 2015 at 07:39, Michal Simek <michal.simek@xilinx.com> wrote:
> Add GPIOLIB dependency for MMC_SDHCI.
>
> Problem was observed after adding the patch
> "mmc: sdhci-of-arasan: Call OF parsing for MMC"
> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls
> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which
> calls devm_gpiod_get_index() which returns -ENOSYS.
>
> Error log:
> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258)
> sdhci-arasan: probe of ff160000.sdhci failed with error -38
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
> After RFC here https://lkml.org/lkml/2015/7/24/371
> adding dependency on MMC_SDHCI.
>
> ---
>  drivers/mmc/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index fd9a58e216a5..5519803c124b 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -38,6 +38,7 @@ config MMC_PXA
>  config MMC_SDHCI
>         tristate "Secure Digital Host Controller Interface support"
>         depends on HAS_DMA
> +       depends on GPIOLIB
>         help
>           This selects the generic Secure Digital Host Controller Interface.
>           It is used by manufacturers such as Texas Instruments(R), Ricoh(R)
> --
> 2.3.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-25 14:10 +0200
  Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-27 13:40 +0200
    Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-27 14:40 +0200
      Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI Ulf Hansson <ulf.hansson@linaro.org> - 2015-08-27 16:20 +0200

csiph-web