Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212941

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

Show key headers only | View raw

On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:

> 
> 
> On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote:
> >On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
> >
> >>Driver had coding style issues where spaces were used instead
> >>of tabs. This patch fixes them all.
> >>
> >>Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
> >>---
> >>  drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
> >>  1 file changed, 61 insertions(+), 64 deletions(-)
> >
> >Same comment as before.
> >
> >How similar is this file to the other one?
> 
> I believe you are referring to include/linux/mfd/88pm80x.h
> 
> >
> >Can you reduce the size by having shared register defines?
> >
> 
> Not sure whether I understand your comment here,
> They are common defines.

I guess the question was a little convoluted.

How about; why are the extra defines in the driver?  Why aren't all of
them in the header file?  What is the difference between the defines
in the C file compared with the ones defined in the header?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 21:00 +0200
  [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 21:00 +0200
    Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 10:10 +0200
      Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 11:00 +0200
        Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Lee Jones <lee.jones@linaro.org> - 2015-08-25 12:40 +0200
          Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 13:00 +0200
  [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-24 21:00 +0200
    Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk  related macros Lee Jones <lee.jones@linaro.org> - 2015-08-25 10:20 +0200
      Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K  clk related macros Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-25 10:50 +0200

csiph-web