Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212935

Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller

Show all headers | View raw

Le 25/08/2015 11:46, Jonas Gorski a écrit :
> On Mon, Aug 24, 2015 at 7:45 PM, Marek Vasut <marex@denx.de> wrote:
>> On Monday, August 24, 2015 at 07:04:38 PM, Cyrille Pitchen wrote:
>>> Hi Marek,
>>
>> Hi!
>>
>>> Le 24/08/2015 13:03, Marek Vasut a écrit :
>>>> On Monday, August 24, 2015 at 12:14:00 PM, Cyrille Pitchen wrote:
>>>>> This driver add support to the new Atmel QSPI controller embedded into
>>>>> sama5d2x SoCs. It expects a NOR memory to be connected to the QSPI
>>>>> controller.
>>
>> [...]
>>
>>>>> +  /* Compute address parameters */
>>>>> +  switch (cmd->enable.bits.address) {
>>>>> +  case 4:
>>>>> +          ifr |= QSPI_IFR_ADDRL;
>>>>> +          /*break;*/ /* fallback to the 24bit address case */
>>>>
>>>> What's this commented out bit of code for ? :-)
>>>
>>> I just wanted to stress out there was no missing "break;".
>>> I've reworded the comment to:
>>> /* No "break" on purpose: fallback to the 24bit address case. */
>>
>> Oh, the address is in bytes . I see, yes, it makes sense to be more
>> explicit here about the purpose of the fallback. I think this change
>> in the comment will make it easier for everyone who comes back in a
>> few years and reads this code.
> 
> I think you are looking for the term "(switch case) fallthrough", not
> "fallback". "Fallback" makes it sound like there is something missing,
> or an invalid state.
> 
> 
> Jonas
> 

will be modified in the next series, thanks for the review!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-08-24 12:20 +0200
  Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Marek Vasut <marex@denx.de> - 2015-08-24 13:10 +0200
    Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-24 15:00 +0200
      Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Marek Vasut <marex@denx.de> - 2015-08-24 15:20 +0200
    Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-08-24 19:10 +0200
      Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Marek Vasut <marex@denx.de> - 2015-08-24 19:50 +0200
        Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Jonas Gorski <jogo@openwrt.org> - 2015-08-25 11:50 +0200
          Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-08-25 12:30 +0200
    Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-08-25 12:20 +0200
      Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller Marek Vasut <marex@denx.de> - 2015-08-25 12:30 +0200
        Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Brian Norris <computersforpeace@gmail.com> - 2015-08-25 18:00 +0200
  RE: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Bean Huo 霍斌斌 (beanhuo)   <beanhuo@micron.com> - 2015-08-25 03:50 +0200
    Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for  Atmel QSPI controller Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-08-25 13:30 +0200

csiph-web