Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212876

[PATCH v7 16/17] KVM: Warn if 'SN' is set during posting interrupts by software

Show all headers | View raw

Currently, we don't support urgent interrupt, all interrupts
are recognized as non-urgent interrupt, so we cannot post
interrupts when 'SN' is set.

If the vcpu is in guest mode, it cannot have been scheduled out,
and that's the only case when SN is set currently, warning if
SN is set.

Signed-off-by: Feng Wu <feng.wu@intel.com>
---
 arch/x86/kvm/vmx.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 64e35ea..eb640a1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4494,6 +4494,22 @@ static inline bool kvm_vcpu_trigger_posted_interrupt(struct kvm_vcpu *vcpu)
 {
 #ifdef CONFIG_SMP
 	if (vcpu->mode == IN_GUEST_MODE) {
+		struct vcpu_vmx *vmx = to_vmx(vcpu);
+
+		/*
+		 * Currently, we don't support urgent interrupt,
+		 * all interrupts are recognized as non-urgent
+		 * interrupt, so we cannot post interrupts when
+		 * 'SN' is set.
+		 *
+		 * If the vcpu is in guest mode, it means it is
+		 * running instead of being scheduled out and
+		 * waiting in the run queue, and that's the only
+		 * case when 'SN' is set currently, warning if
+		 * 'SN' is set.
+		 */
+		WARN_ON_ONCE(pi_test_sn(&vmx->pi_desc));
+
 		apic->send_IPI_mask(get_cpu_mask(vcpu->cpu),
 				POSTED_INTR_VECTOR);
 		return true;
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 00/17] Add VT-d Posted-Interrupts support Feng Wu <feng.wu@intel.com> - 2015-08-25 11:10 +0200
  [PATCH v7 02/17] KVM: Add some helper functions for Posted-Interrupts Feng Wu <feng.wu@intel.com> - 2015-08-25 11:10 +0200
  [PATCH v7 08/17] vfio: Select IRQ_BYPASS_MANAGER for vfio PCI devices Feng Wu <feng.wu@intel.com> - 2015-08-25 11:10 +0200
  [PATCH v7 11/17] KVM: Define two weak arch callbacks for irq bypass manager Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 16/17] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 14/17] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 15/17] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
    Re: [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts Alex Williamson <alex.williamson@redhat.com> - 2015-08-25 22:00 +0200
      RE: [PATCH v7 10/17] KVM: x86: Update IRTE for posted-interrupts "Wu, Feng" <feng.wu@intel.com> - 2015-08-26 02:40 +0200
  [PATCH v7 12/17] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 13/17] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 17/17] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu <feng.wu@intel.com> - 2015-08-25 11:20 +0200
  [PATCH v7 07/17] KVM: make kvm_set_msi_irq() public Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200
  [PATCH v7 09/17] vfio: Register/unregister irq_bypass_producer Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200
  [PATCH v7 01/17] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200
  [PATCH v7 03/17] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200
  [PATCH v7 05/17] KVM: Add interfaces to control PI outside vmx Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200
  [PATCH v7 06/17] KVM: Make struct kvm_irq_routing_table accessible Feng Wu <feng.wu@intel.com> - 2015-08-25 11:30 +0200

csiph-web