[RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return

From	Xing Zheng <zhengxing@rock-chips.com>
Newsgroups	linux.kernel
Subject	[RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return
Date	2015-08-25 10:10 +0200
Message-ID	<q1hsS-Dz-3@gated-at.bofh.it> (permalink)
References	<q1hsS-Dz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Being careless, judge the return value of snd_soc_card_jack_new
is opposite, so it should be fixed.

---

Changes in v1:
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

 sound/soc/rockchip/rockchip_rt5645.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/rockchip/rockchip_rt5645.c b/sound/soc/rockchip/rockchip_rt5645.c
index 3c6bb1e..adfe98c 100644
--- a/sound/soc/rockchip/rockchip_rt5645.c
+++ b/sound/soc/rockchip/rockchip_rt5645.c
@@ -118,7 +118,7 @@ static int rk_init(struct snd_soc_pcm_runtime *runtime)
 				    SND_JACK_BTN_0 | SND_JACK_BTN_1 |
 				    SND_JACK_BTN_2 | SND_JACK_BTN_3,
 				    &headset_jack, NULL, 0);
-	if (!ret) {
+	if (ret) {
 		dev_err(card->dev, "New Headset Jack failed! (%d)\n", ret);
 		return ret;
 	}
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[RESEND PATCH v1] ASoC: rockchip: fix a misjudgement by return Xing Zheng <zhengxing@rock-chips.com> - 2015-08-25 10:10 +0200

csiph-web