Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212793

[PATCH] mm/backing-dev: Check return value of the debugfs_create_dir()

Show all headers | View raw

The debugfs_create_dir() function may fail and return error. If the
root directory not created, we can't create anything inside it. This
patch adds check for this case.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 mm/backing-dev.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index dac5bf5..518d26a 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -117,15 +117,21 @@ static const struct file_operations bdi_debug_stats_fops = {
 
 static void bdi_debug_register(struct backing_dev_info *bdi, const char *name)
 {
-	bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root);
-	bdi->debug_stats = debugfs_create_file("stats", 0444, bdi->debug_dir,
-					       bdi, &bdi_debug_stats_fops);
+	if (bdi_debug_root) {
+		bdi->debug_dir = debugfs_create_dir(name, bdi_debug_root);
+		if (bdi->debug_dir)
+			bdi->debug_stats = debugfs_create_file("stats", 0444,
+							bdi->debug_dir, bdi,
+							&bdi_debug_stats_fops);
+	}
 }
 
 static void bdi_debug_unregister(struct backing_dev_info *bdi)
 {
-	debugfs_remove(bdi->debug_stats);
-	debugfs_remove(bdi->debug_dir);
+	if (bdi_debug_root) {
+		debugfs_remove(bdi->debug_stats);
+		debugfs_remove(bdi->debug_dir);
+	}
 }
 #else
 static inline void bdi_debug_init(void)
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/backing-dev: Check return value of the debugfs_create_dir() Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-25 10:20 +0200
  Re: [PATCH] mm/backing-dev: Check return value of the  debugfs_create_dir() Jan Kara <jack@suse.cz> - 2015-08-25 10:40 +0200
  Re: [PATCH] mm/backing-dev: Check return value of the  debugfs_create_dir() Andrew Morton <akpm@linux-foundation.org> - 2015-08-25 23:10 +0200
    Re: [PATCH] mm/backing-dev: Check return value of the  debugfs_create_dir() Jan Kara <jack@suse.cz> - 2015-08-26 11:30 +0200
      Re: [PATCH] mm/backing-dev: Check return value of the debugfs_create_dir() Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-26 12:20 +0200

csiph-web