Re: [PATCHv2 2/4] zsmalloc: use page->private instead of page->first_page

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 2/4] zsmalloc: use page->private instead of page->first_page
Date	2015-08-25 04:20 +0200
Message-ID	<q1c09-1i6-7@gated-at.bofh.it> (permalink)
References	<pYucV-2sM-9@gated-at.bofh.it> <pYucW-2sM-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (08/17/15 18:09), Kirill A. Shutemov wrote:
[..]
> @@ -980,7 +979,7 @@ static struct page *alloc_zspage(struct size_class *class, gfp_t flags)
>  		if (i == 1)
>  			set_page_private(first_page, (unsigned long)page);
>  		if (i >= 1)
> -			page->first_page = first_page;
> +			set_page_private(first_page, (unsigned long)first_page);

This patch breaks zram/zsmalloc.

Shouldn't it be `page->private = first_page' instead of
`first_page->private = first_page'? IOW:

-	set_page_private(first_page, (unsigned long)first_page);
+	set_page_private(page, (unsigned long)first_page);

?

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2 2/4] zsmalloc: use page->private instead of  page->first_page Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-25 04:20 +0200
  Re: [PATCHv2 2/4] zsmalloc: use page->private instead of  page->first_page "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-08-25 19:20 +0200

csiph-web