Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE

From	yalin wang <yalin.wang2010@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Date	2015-08-25 04:10 +0200
Message-ID	<q1bQu-10P-13@gated-at.bofh.it> (permalink)
References	<q17Dc-3fk-15@gated-at.bofh.it> <q1aB3-7vp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Aug 25, 2015, at 08:48, Corey Minyard <minyard@acm.org> wrote:
> 
> Well, I should have compile tested first.  On x86_64:
> 
> 
>  CC [M]  drivers/char/ipmi/ipmi_si_intf.o
> In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0:
> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ‘ipmi_match’
> undeclared here (not in a function)
> MODULE_DEVICE_TABLE(of, ipmi_match);
>                         ^
> ../include/linux/module.h:223:21: note: in definition of macro
> ‘MODULE_DEVICE_TABLE’
> extern const typeof(name) __mod_##type##__##name##_device_table \
>                     ^
> ../include/linux/module.h:223:27: error:
> ‘__mod_of__ipmi_match_device_table’ aliased to undefined symbol ‘ipmi_match’
> extern const typeof(name) __mod_##type##__##name##_device_table \
>                           ^
> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro
> ‘MODULE_DEVICE_TABLE’
> MODULE_DEVICE_TABLE(of, ipmi_match);
> 
> 
> This has to compile on all arches.  I'm not sure what is wrong, but I've
> removed the patch.
> 
> -corey
it seems should be :

MODULE_DEVICE_TABLE(of, of_ipmi_match);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE Corey Minyard <minyard@acm.org> - 2015-08-25 02:50 +0200
  Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE yalin wang <yalin.wang2010@gmail.com> - 2015-08-25 04:10 +0200
    Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE Corey Minyard <minyard@acm.org> - 2015-08-25 14:00 +0200
  Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE Corey Minyard <minyard@acm.org> - 2015-08-26 17:00 +0200

csiph-web