Re: [RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode()

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode()
Date	Wed, 26 Aug 2015 22:10:01 +0200
Message-ID	<q1Pbb-7Bp-7@gated-at.bofh.it> (permalink)
References	<q1NVM-5DV-21@gated-at.bofh.it> <q1ORQ-6Zw-17@gated-at.bofh.it>
X-Original-To	Jeremy Linton <jeremy.linton@arm.com>, Steve Glendinning <steve.glendinning@shawell.net>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=nGsowruFoSR3suEpdPHpeliGC23CiTasHu+mKeq6R/c=; b=rtLlx5aYvIf7RXWO+xwJmEpc5iLetO3HVAEngI9F1dOEiu5sFq7lcJHfBh4jPkRKaynUvw3v716rS8bu2Vks/s+/MohvwR9m1bRr+sxWPeyBWY1Twyr2VV43KA9toYta07E9PcGzR1aepCRsYuE2G/ohCZhhSFOEm5nDGl17dDc=;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Authenticated_Sender	linux@roeck-us.net
X-Outgoing-Spam-Status	No, score=-1.0
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - bh-25.webhostbox.net
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via	bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tony@atomide.com" <tony@atomide.com>
X-Original-Date	Wed, 26 Aug 2015 13:07:15 -0700
X-Original-Message-ID	<55DE1C73.7070000@roeck-us.net>
X-Original-References	<1440614948-27428-1-git-send-email-linux@roeck-us.net> <55DE1735.3070106@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1214159

Show key headers only | View raw

On 08/26/2015 12:44 PM, Jeremy Linton wrote:
> On 08/26/2015 01:49 PM, Guenter Roeck wrote:
>> Check the return value from device_property_read_u32() to see if there
>> is a suitable firmware interface to read the data, and abort if not.
>> The function should return -ENXIO in that case; however, it returns
>> -ENODATA. Check for both.
>>
>> Fixes: 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Needs testing. RFC because I am not sure if the -ENODATA check is acceptable.
>
> I'm not really sure about it myself. I can think of cases where it might cause problems. That said it does work in an ACPI environment with or without the _DSD block. If the DSD/property isn't set, obviously the device doesn't configure (but it doesn't crash either) so that is good and an overall improvement for ACPI.
>
> Also, I personally might have hoisted the reg-io-width ahead of the device_get_phy_mode() and removed the phy checks, but I don't imagine there is much functional difference at this point.
>
> Tested-by: Jeremy Linton <jeremy.linton@arm.com>
>

I'll post a separate two-patch series which introduces -ENXIO as return value.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode() Guenter Roeck <linux@roeck-us.net> - 2015-08-26 20:50 +0200
  Re: [RFC PATCH] smsc911x: Ignore error return from  device_get_phy_mode() Jeremy Linton <jeremy.linton@arm.com> - 2015-08-26 21:50 +0200
    Re: [RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode() Guenter Roeck <linux@roeck-us.net> - 2015-08-26 22:10 +0200

csiph-web