Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214187

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

Show all headers | View raw

Hi Tony,

On 08/26/2015 01:16 PM, Tony Lindgren wrote:
[ ... ]

>> We may need two separate patches, one to fix up device_property_read_u32()
>> to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error
>> from device_get_phy_mode(), and to bail out if device_property_read_u32()
>> returns -ENXIO.
>
> I guess the device_property_read_u32() change needs to be discussed
> separately.. So probably best to fix up the regression to smsc911x
> first.
>
Not sure myself. Jeremy has a point - we don't really know for sure how
safe it is to check for -ENODATA (in addition to -ENXIO). Also, fixing
device_property_read_u32() turned out to be much easier than I thought.

>> The simpler alternative would be to check the return value from
>> device_property_read_u32() for both -ENXIO and -ENODATA.
>> This would make the code independent of the necessary core changes
>> (which may take a while). I tested this variant, and it works, at least
>> for the non-DT case.
>>
>> Does this make sense ?
>
> Yeh I think that would allow fixing up the smsc911x regression while
> discussing the device_property_read_u32() change. Got a test patch
> for me to try?
>

You should have two by now to choose from.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Tony Lindgren <tony@atomide.com> - 2015-08-26 19:10 +0200
  Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Jeremy Linton <jeremy.linton@arm.com> - 2015-08-26 19:40 +0200
    Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Tony Lindgren <tony@atomide.com> - 2015-08-26 19:50 +0200
  Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF  is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-26 19:40 +0200
    Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Tony Lindgren <tony@atomide.com> - 2015-08-26 20:00 +0200
  Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF  is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-26 20:40 +0200
    Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Tony Lindgren <tony@atomide.com> - 2015-08-26 22:20 +0200
      Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF  is configured or used Guenter Roeck <linux@roeck-us.net> - 2015-08-26 23:00 +0200
        Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is  configured or used Tony Lindgren <tony@atomide.com> - 2015-08-26 23:50 +0200

csiph-web