Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214140

Re: [PATCH] media/pci/cobalt: Use %*ph to print small buffers

Show all headers | View raw

Oh, nope, resent

2015-08-27 0:56 GMT+06:00 Joe Perches <joe@perches.com>:
> On Thu, 2015-08-27 at 00:51 +0600, Alexander Kuleshov wrote:
>> printk() supports %*ph format specifier for printing a small buffers,
>> let's use it intead of %02x %02x...
>
> Having just suffered this myself...
>
>> diff --git a/drivers/media/pci/cobalt/cobalt-cpld.c b/drivers/media/pci/cobalt/cobalt-cpld.c
> []
>> @@ -330,9 +330,7 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out)
>>
>>               if (!memcmp(read_regs, regs, sizeof(read_regs)))
>>                       break;
>> -             cobalt_dbg(1, "retry: %02x %02x %02x %02x %02x %02x\n",
>> -                     read_regs[0], read_regs[1], read_regs[2],
>> -                     read_regs[3], read_regs[4], read_regs[5]);
>> +             cobalt_dbg(1, "retry: %6ph\n");
>
> Aren't you missing something like compile testing?
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] media/pci/cobalt: Use %*ph to print small buffers Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-26 21:00 +0200
  Re: [PATCH] media/pci/cobalt: Use %*ph to print small buffers Joe Perches <joe@perches.com> - 2015-08-26 21:00 +0200
    Re: [PATCH] media/pci/cobalt: Use %*ph to print small buffers Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-26 21:10 +0200

csiph-web