Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1214100

Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter

Show all headers | View raw

On 26 August 2015 at 19:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Wed, Aug 26, 2015 at 06:24:55PM +0100, Matt Fleming wrote:
>> On Wed, 26 Aug, at 02:24:57PM, Leif Lindholm wrote:
>> > Now that we have an efi=debug command line option in the core code, use
>> > this instead of the arm64-specific uefi_debug option.
>> >
>> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> > ---
>> >  Documentation/arm/uefi.txt |  2 --
>> >  arch/arm64/kernel/efi.c    | 19 +++++--------------
>> >  2 files changed, 5 insertions(+), 16 deletions(-)
>>
>> Are there no concerns with backwards-compatibility here? I expected
>> this patch to internally convert uefi_debug to efi=debug if old boot
>> loaders, kernel config, etc specify it.
>>
>> Is that something that can be safely ignored?
>
> Since it is purely a debug feature, I opted to just drop it.
> I don't have strong feelings, and it could certainly be kept as an
> arm64-only alias (but setting the EFI_DBG flag) if others disagree.
>

Let's not bother. This is strictly a debug option that only affects
what gets printed to the kernel log, which itself is not (or should
not be) an ABI. Also, if anyone cares deeply about always having the
feature enabled both on before and after kernels, they can always pass
both options.

-- 
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter Leif Lindholm <leif.lindholm@linaro.org> - 2015-08-26 15:30 +0200
  Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug  command line parameter Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-26 19:30 +0200
    Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug  command line parameter Leif Lindholm <leif.lindholm@linaro.org> - 2015-08-26 19:40 +0200
      Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug  command line parameter Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-08-26 20:30 +0200
  Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug  command line parameter Matt Fleming <matt@codeblueprint.co.uk> - 2015-08-28 15:40 +0200

csiph-web