Re: [v2] net: phy: fixed: propagate fixed link values to struct

From	Stas Sergeev <stsp@list.ru>
Newsgroups	linux.kernel
Subject	Re: [v2] net: phy: fixed: propagate fixed link values to struct
Date	2015-08-26 18:00 +0200
Message-ID	<q1Lhf-1M3-7@gated-at.bofh.it> (permalink)
References	<q1Lhf-1M3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

26.08.2015 17:58, Madalin Bucur пишет:
> The fixed link values parsed from the device tree are stored in
> the struct fixed_phy member status. The struct phy_device members
> speed, duplex were not updated.

ACK, but IMHO it will make more sense if you include that
into your upcoming patch set rather than sending separately,
as otherwise there is simply no in-kernel users of that new
functionality (all the current users likely do not access
these fields as early as you want to, so they don't care).
In any case, the patch looks good to me and the policy is
up to others.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [v2] net: phy: fixed: propagate fixed link values to struct Stas Sergeev <stsp@list.ru> - 2015-08-26 18:00 +0200
  RE: [v2] net: phy: fixed: propagate fixed link values to struct Madalin-Cristian Bucur <madalin.bucur@freescale.com> - 2015-08-26 18:20 +0200

csiph-web