Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1213958
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 0/2] Patches to test MC next gen patches in OMAP3 ISP |
| Date | 2015-08-26 17:30 +0200 |
| Message-ID | <q1KOe-1e0-17@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Hello, This series contains two patches that are needed to test the "[PATCH v7 00/44] MC next generation patches" [0] in a OMAP3 board by using the omap3isp driver. I found two issues during testing, the first one is that the media_entity_cleanup() function tries to empty the pad links list but the list is initialized when a entity is registered causing a NULL pointer deference error. The second issue is that the omap3isp driver creates links when the entities are initialized but before the media device is registered causing a NULL pointer deference as well. Patch 1/1 fixes the first issue by removing the links list empty logic from media_entity_cleanup() since that is made in media_device_unregister_entity() and 2/2 fixes the second issue by separating the entities initialization from the pads links creation after the entities have been registered. Patch 1/1 was posted before [1] but forgot to add the [media] prefix in the subject line so I'm including in this set again. Sorry about that. The testing was made on an OMAP3 DM3735 IGEPv2 board and test that the media-ctl -p prints out the topology. More extensive testing will be made but I wanted to share these patches in order to make easier for other people that were looking at it. [0]: https://www.mail-archive.com/linux-media@vger.kernel.org/msg91528.html [1]: https://lkml.org/lkml/2015/8/24/649 Best regards, Javier Javier Martinez Canillas (2): [media] media: don't try to empty links list in media_entity_cleanup() [media] omap3isp: separate links creation from entities init drivers/media/media-entity.c | 7 -- drivers/media/platform/omap3isp/isp.c | 152 +++++++++++++++++---------- drivers/media/platform/omap3isp/ispccdc.c | 22 ++-- drivers/media/platform/omap3isp/ispccdc.h | 1 + drivers/media/platform/omap3isp/ispccp2.c | 22 ++-- drivers/media/platform/omap3isp/ispccp2.h | 1 + drivers/media/platform/omap3isp/ispcsi2.c | 22 ++-- drivers/media/platform/omap3isp/ispcsi2.h | 1 + drivers/media/platform/omap3isp/isppreview.c | 33 +++--- drivers/media/platform/omap3isp/isppreview.h | 1 + drivers/media/platform/omap3isp/ispresizer.c | 33 +++--- drivers/media/platform/omap3isp/ispresizer.h | 1 + 12 files changed, 185 insertions(+), 111 deletions(-) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 0/2] Patches to test MC next gen patches in OMAP3 ISP Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-26 17:30 +0200
[PATCH 2/2] [media] omap3isp: separate links creation from entities init Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-26 17:30 +0200
Re: [PATCH 2/2] [media] omap3isp: separate links creation from entities init Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2015-08-26 22:50 +0200
Re: [PATCH 2/2] [media] omap3isp: separate links creation from entities init Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-27 10:10 +0200
[PATCH 1/2] [media] media: don't try to empty links list in media_entity_cleanup() Javier Martinez Canillas <javier@osg.samsung.com> - 2015-08-26 17:30 +0200
csiph-web