Re: [PATCH] of: device: fix NULL pointer dereference on driver removal

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] of: device: fix NULL pointer dereference on driver removal
Date	2015-08-26 16:20 +0200
Message-ID	<q1JIu-88h-3@gated-at.bofh.it> (permalink)
References	<q1seC-7G4-21@gated-at.bofh.it> <q1IMq-6N8-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 26, 2015 at 08:14:36AM -0500, Rob Herring wrote:
> On Tue, Aug 25, 2015 at 2:34 PM, Felipe Balbi <balbi@ti.com> wrote:
> > If we don't insert resources into the resource tree,
> > calls to of_platform_depopulate() will end up in NULL
> > pointer dereferences because the resource parent will
> > be set to NULL even though we still have more resources
> > to go through.
> 
> Long standing problem. A fix is in -next now and will go into 4.3 (plus stable):
> 
> commit 11c63e4718acad3d8f04601c80fddd4b3d1455b1
> Author: Grant Likely <grant.likely@linaro.org>
> Date:   Sun Jun 7 15:20:11 2015 +0100
> 
>     drivercore: Fix unregistration path of platform devices

that commit works, but too late to add a Tested-by :-)

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] of: device: fix NULL pointer dereference on driver removal Felipe Balbi <balbi@ti.com> - 2015-08-25 21:40 +0200
  Re: [PATCH] of: device: fix NULL pointer dereference on driver removal Rob Herring <robherring2@gmail.com> - 2015-08-26 15:20 +0200
    Re: [PATCH] of: device: fix NULL pointer dereference on driver  removal Felipe Balbi <balbi@ti.com> - 2015-08-26 16:20 +0200

csiph-web