Re: [PATCH 11/11] gpio: xlp: fix error return code

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/11] gpio: xlp: fix error return code
Date	2015-08-26 15:00 +0200
Message-ID	<q1It4-6bl-5@gated-at.bofh.it> (permalink)
References	<q0rkB-1su-3@gated-at.bofh.it> <q0rkD-1su-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 23, 2015 at 2:11 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 11/11] gpio: xlp: fix error return code Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-23 02:30 +0200
  Re: [PATCH 11/11] gpio: xlp: fix error return code Linus Walleij <linus.walleij@linaro.org> - 2015-08-26 15:00 +0200

csiph-web