Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213630

[PATCH v2 4/4] tracing/uprobes: Do not print '0x (null)' when offset is 0

Show all headers | View raw

When manually added uprobe point with zero address, 'uprobe_events' output
'(null)' instead of 0x00000000:

 # echo p:probe_libc/abs_0 /path/to/lib.bin:0x0 arg1=%ax > \
            /sys/kernel/debug/tracing/uprobe_events

 # cat /sys/kernel/debug/tracing/uprobe_events
   p:probe_libc/abs_0 /path/to/lib.bin:0x          (null) arg1=%ax

This patch fixes this behavior:

 # cat /sys/kernel/debug/tracing/uprobe_events
 p:probe_libc/abs_0 /path/to/lib.bin:0x0000000000000000

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace_uprobe.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index f97479f..d2f6d0b 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -601,7 +601,22 @@ static int probes_seq_show(struct seq_file *m, void *v)
 
 	seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
 			trace_event_name(&tu->tp.call));
-	seq_printf(m, " %s:0x%p", tu->filename, (void *)tu->offset);
+	seq_printf(m, " %s:", tu->filename);
+
+	/* Don't print "0x  (null)" when offset is 0 */
+	if (tu->offset) {
+		seq_printf(m, "0x%p", (void *)tu->offset);
+	} else {
+		switch (sizeof(void *)) {
+		case 4:
+			seq_printf(m, "0x00000000");
+			break;
+		case 8:
+		default:
+			seq_printf(m, "0x0000000000000000");
+			break;
+		}
+	}
 
 	for (i = 0; i < tu->tp.nr_args; i++)
 		seq_printf(m, " %s=%s", tu->tp.args[i].name, tu->tp.args[i].comm);
-- 
1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at absolute address Wang Nan <wangnan0@huawei.com> - 2015-08-26 09:50 +0200
  [PATCH v2 1/4] perf probe: Prevent segfault when reading probe point with absolute address Wang Nan <wangnan0@huawei.com> - 2015-08-26 09:50 +0200
  [PATCH v2 2/4] perf probe: Fix list result when address is zero Wang Nan <wangnan0@huawei.com> - 2015-08-26 09:50 +0200
    RE: [PATCH v2 2/4] perf probe: Fix list result when address is zero 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2015-08-26 11:30 +0200
      Re: [PATCH v2 2/4] perf probe: Fix list result when address is zero "Wangnan (F)" <wangnan0@huawei.com> - 2015-08-26 11:50 +0200
        RE: [PATCH v2 2/4] perf probe: Fix list result when address is zero 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2015-08-26 12:50 +0200
  [PATCH v2 4/4] tracing/uprobes: Do not print '0x  (null)' when offset is 0 Wang Nan <wangnan0@huawei.com> - 2015-08-26 09:50 +0200
    RE: [PATCH v2 4/4] tracing/uprobes: Do not print '0x  (null)' when  offset is 0 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2015-08-26 12:10 +0200
  [PATCH v2 3/4] perf probe: Support probing at absolute address Wang Nan <wangnan0@huawei.com> - 2015-08-26 09:50 +0200
    RE: [PATCH v2 3/4] perf probe: Support probing at absolute address 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2015-08-26 11:50 +0200
  RE: [PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at  absolute address 平松雅巳 / HIRAMATU，MASAMI   <masami.hiramatsu.pt@hitachi.com> - 2015-08-26 11:20 +0200

csiph-web