Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213549

Re: [PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister

Show all headers | View raw

On Wed, 2015-08-26 at 13:39 +0800, Jason Wang wrote:
> 
> On 08/25/2015 11:29 PM, Joe Perches wrote:
> > On Tue, 2015-08-25 at 15:47 +0800, Jason Wang wrote:
> >> > All fields of kvm_io_range were initialized or copied explicitly
> >> > afterwards. So switch to use kmalloc().
> > Is there any compiler added alignment padding
> > in either structure?  If so, those padding
> > areas would now be uninitialized and may leak
> > kernel data if copied to user-space.
> >
> I get your concern, but I don't a way to copy them to userspace, did you?

I didn't look.

I just wanted you to be aware there's a difference
and a reason why kzalloc might be used even though
all structure members are initialized.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during iodev register/unregister Jason Wang <jasowang@redhat.com> - 2015-08-25 09:50 +0200
  Re: [PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during  iodev register/unregister Joe Perches <joe@perches.com> - 2015-08-25 17:30 +0200
    Re: [PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during  iodev register/unregister Jason Wang <jasowang@redhat.com> - 2015-08-26 07:40 +0200
      Re: [PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during  iodev register/unregister Joe Perches <joe@perches.com> - 2015-08-26 07:50 +0200
        Re: [PATCH V2 1/3] kvm: use kmalloc() instead of kzalloc() during  iodev register/unregister Jason Wang <jasowang@redhat.com> - 2015-08-26 07:50 +0200

csiph-web