Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212567

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

Show all headers | View raw

Hi Chao,

On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote:
> On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote:
> > In following call stack, if unfortunately we lose all chances to truncate
> > inode page in remove_inode_page, eventually we will add the nid allocated
> > previously into free nid cache, this nid is with NID_NEW status and with
> > NEW_ADDR in its blkaddr pointer:
> > 
> >  - f2fs_create
> >   - f2fs_add_link
> >    - __f2fs_add_link
> >     - init_inode_metadata
> >      - new_inode_page
> >       - new_node_page
> >        - set_node_addr(, NEW_ADDR)
> >      - f2fs_init_acl   failed
> >      - remove_inode_page  failed
> >   - handle_failed_inode
> >    - remove_inode_page  failed
> >    - iput
> >     - f2fs_evict_inode
> >      - remove_inode_page  failed
> >      - alloc_nid_failed   cache a nid with valid blkaddr: NEW_ADDR

Unfortunately, this couldn't fix my bug case.
I'm still struggling to find out something tho.
Meanwhile, let's stay with both of the patches.

Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] f2fs: fix to release inode correctly Chao Yu <chao2.yu@samsung.com> - 2015-08-24 11:50 +0200
  Re: [PATCH 2/2] f2fs: fix to release inode correctly Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-24 19:00 +0200
    Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-25 01:00 +0200
      RE: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly Chao Yu <chao2.yu@samsung.com> - 2015-08-25 08:50 +0200
        Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-26 00:50 +0200
          RE: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly Chao Yu <chao2.yu@samsung.com> - 2015-08-26 14:50 +0200
    RE: [PATCH 2/2] f2fs: fix to release inode correctly Chao Yu <chao2.yu@samsung.com> - 2015-08-25 03:50 +0200
      Re: [PATCH 2/2] f2fs: fix to release inode correctly Jaegeuk Kim <jaegeuk@kernel.org> - 2015-08-26 00:20 +0200

csiph-web