Re: [PATCH 2/2] cgroup: pids: fix invalid get/put usage

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] cgroup: pids: fix invalid get/put usage
Date	2015-08-24 21:10 +0200
Message-ID	<q15i2-8if-15@gated-at.bofh.it> (permalink)
References	<q0Czn-HK-5@gated-at.bofh.it> <q0DlL-1Rq-3@gated-at.bofh.it> <q0DlO-1Rq-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Sun, Aug 23, 2015 at 11:10:32PM +1000, Aleksa Sarai wrote:
> Fix incorrect usage of css_get and css_put to put a different css in
> pids_{cancel_,}attach() than the one grabbed in pids_can_attach(). This
> could lead to quite serious memory leakage (and unsafe operations on the
> putted css).

So, this patch looks correct to me but can you update the description
so that it notes that the source css doesn't go away while migration
is in progress and thus pinning is unnecessary to begin with?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: Bad Reference Semantics in PIDs Controller. Aleksa Sarai <cyphar@cyphar.com> - 2015-08-23 14:30 +0200
  Re: [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai <cyphar@cyphar.com> - 2015-08-23 15:20 +0200
  [PATCH 1/2] cgroup: get a ref to source csses when migrating Aleksa Sarai <cyphar@cyphar.com> - 2015-08-23 15:20 +0200
    Re: [PATCH 1/2] cgroup: get a ref to source csses when migrating Tejun Heo <tj@kernel.org> - 2015-08-24 20:50 +0200
      Re: [PATCH 1/2] cgroup: get a ref to source csses when migrating Aleksa Sarai <cyphar@cyphar.com> - 2015-08-25 04:10 +0200
        Re: [PATCH 1/2] cgroup: get a ref to source csses when migrating Tejun Heo <tj@kernel.org> - 2015-08-25 20:20 +0200
  [PATCH 0/2] cgroup: pids: fix invalid reference semantics Aleksa Sarai <cyphar@cyphar.com> - 2015-08-23 15:20 +0200
    [PATCH 2/2] cgroup: pids: fix invalid get/put usage Aleksa Sarai <cyphar@cyphar.com> - 2015-08-23 15:20 +0200
      Re: [PATCH 2/2] cgroup: pids: fix invalid get/put usage Tejun Heo <tj@kernel.org> - 2015-08-24 21:10 +0200

csiph-web