Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212452

Re: [PATCH] staging: fbtft: Made into two lines

Show all headers | View raw

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?

Better. Also, submit it again with proper commit message and put "PATCH v2" in
the subject.

> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
>  drivers/staging/fbtft/fb_pcd8544.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
>  #define WIDTH          84
>  #define HEIGHT         48
>  #define TXBUFLEN       (84*6)
> -#define DEFAULT_GAMMA  "40"
>  /* gamma is used to control contrast in this driver */

Aren't these two supposed to be on the same line? I think your patch is a bit
messed up. Doublecheck this.

> +#define DEFAULT_GAMMA  "40"
>  
>  static unsigned tc;
>  module_param(tc, uint, 0);
> -- 
> 1.7.9.5
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fbtft: Made into two lines Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-21 15:10 +0200
  Re: [PATCH] staging: fbtft: Made into two lines Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2015-08-23 10:00 +0200
  [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi <kdasaparna@gmail.com> - 2015-08-23 15:30 +0200
    Re: [PATCH] staging: fbtft: Made into two lines Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2015-08-24 21:10 +0200
    Re: [PATCH] staging: fbtft: Made into two lines Giedrius Statkevičius   <giedrius.statkevicius@gmail.com> - 2015-08-24 21:40 +0200
  Re: [PATCH] staging: fbtft: Made into two lines Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-24 15:20 +0200

csiph-web