Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212390

Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c

Show all headers | View raw

On Tue, 25 Aug 2015, fu.wei@linaro.org wrote:

You Cc the world and some more on your patch, but you fail to add the
maintainers of the clocksource code to the Cc list. Sigh.

> From: Fu Wei <fu.wei@linaro.org>
> 
> The patch update arm_arch_timer driver to use the function
> provided by the new GTDT driver of ACPI.
> By this way, arm_arch_timer.c can be simplified, and separate
> all the ACPI GTDT knowledge from this timer driver.

That's not a proper changelog and this patch want's to be split in two:

1) Implement the new ACPI function

2) Make use of it
 
> index 0aa135d..99505bb 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -817,68 +817,30 @@ CLOCKSOURCE_OF_DECLARE(armv7_arch_timer_mem, "arm,armv7-timer-mem",
>  		       arch_timer_mem_init);
>  
>  #ifdef CONFIG_ACPI
> -static int __init map_generic_timer_interrupt(u32 interrupt, u32 flags)
> -{
> -	int trigger, polarity;
> -
> -	if (!interrupt)
> -		return 0;
> -
> -	trigger = (flags & ACPI_GTDT_INTERRUPT_MODE) ? ACPI_EDGE_SENSITIVE
> -			: ACPI_LEVEL_SENSITIVE;
> -
> -	polarity = (flags & ACPI_GTDT_INTERRUPT_POLARITY) ? ACPI_ACTIVE_LOW
> -			: ACPI_ACTIVE_HIGH;
> -
> -	return acpi_register_gsi(NULL, interrupt, trigger, polarity);
> -}
> -
>  /* Initialize per-processor generic timer */
> -static int __init arch_timer_acpi_init(struct acpi_table_header *table)
> +void __init arch_timer_acpi_init(void)
>  {

And how is that supposed to work when we have next generation CPUs
which implement a different timer? You break multisystem kernels that
way.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c fu.wei@linaro.org - 2015-08-24 19:10 +0200
  Re: [PATCH v7 8/8] clocksource: simplify ACPI code in  arm_arch_timer.c Thomas Gleixner <tglx@linutronix.de> - 2015-08-24 20:00 +0200
    Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c Fu Wei <fu.wei@linaro.org> - 2015-08-25 19:20 +0200
      Re: [PATCH v7 8/8] clocksource: simplify ACPI code in  arm_arch_timer.c Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 21:20 +0200
        Re: [PATCH v7 8/8] clocksource: simplify ACPI code in  arm_arch_timer.c Thomas Gleixner <tglx@linutronix.de> - 2015-08-27 14:10 +0200
          Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c Hanjun Guo <hanjun.guo@linaro.org> - 2015-08-27 14:30 +0200
            Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c Hanjun Guo <hanjun.guo@linaro.org> - 2015-08-27 15:40 +0200
              Re: [PATCH v7 8/8] clocksource: simplify ACPI code in  arm_arch_timer.c Thomas Gleixner <tglx@linutronix.de> - 2015-08-27 15:50 +0200
                Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c Fu Wei <fu.wei@linaro.org> - 2015-08-27 16:00 +0200
        Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c Hanjun Guo <hanjun.guo@linaro.org> - 2015-08-27 14:10 +0200

csiph-web