Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API

From	Tadeusz Struk <tadeusz.struk@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API
Date	2015-08-24 19:50 +0200
Message-ID	<q142B-6gB-5@gated-at.bofh.it> (permalink)
References	<pWRQm-8uz-5@gated-at.bofh.it> <pWRQm-8uz-15@gated-at.bofh.it> <pXO42-Eu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Stephan,

On 08/15/2015 11:08 AM, Stephan Mueller wrote:
> Am Mittwoch, 12. August 2015, 20:54:39 schrieb Tadeusz Struk:
> 
> Hi Tadeusz,
> 
>> @@ -41,7 +41,7 @@ struct pkcs7_parse_context {
>> static void pkcs7_free_signed_info(struct pkcs7_signed_info *sinfo)
>> {
>> 	if (sinfo) {
>> -		mpi_free(sinfo->sig.mpi[0]);
>> +		kfree(sinfo->sig.s);
> 
> kzfree?
> 
>> 		kfree(sinfo->sig.digest);
> 
> kzfree?
> 
>> 		kfree(sinfo->signing_cert_id);
>> 		kfree(sinfo);
> 
> kzfree (due to ->msdigest)?
> 

Sorry for late response. I was on vacation.
All these above are module signatures, which are not sensitive,
so no need to zero the buffers on free.
The only thing that is sensitive is the private key,
which is only used for signing modules on make modules_install
and never included in the kernel.
Thanks,
T
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] crypto: KEYS: convert public key to the akcipher API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-24 19:50 +0200

csiph-web