Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1212191

[PATCH] clockevents/drivers/mtk: Fix spurious interrupt leading to crash

Show all headers | View raw

After analysis done by Yingjoe Chen, the timer appears to have a pending
interrupt when it is enabled.

Fix this by acknowledging the pending interrupt when enabling the timer
interrupt.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/mtk_timer.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
index 4cd16fb..13543a8 100644
--- a/drivers/clocksource/mtk_timer.c
+++ b/drivers/clocksource/mtk_timer.c
@@ -156,14 +156,6 @@ static irqreturn_t mtk_timer_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static void mtk_timer_global_reset(struct mtk_clock_event_device *evt)
-{
-	/* Disable all interrupts */
-	writel(0x0, evt->gpt_base + GPT_IRQ_EN_REG);
-	/* Acknowledge all interrupts */
-	writel(0x3f, evt->gpt_base + GPT_IRQ_ACK_REG);
-}
-
 static void
 mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option)
 {
@@ -183,6 +175,9 @@ static void mtk_timer_enable_irq(struct mtk_clock_event_device *evt, u8 timer)
 {
 	u32 val;
 
+        /* Acknowledge all spurious pending interrupts */
+        writel(0x3f, evt->gpt_base + GPT_IRQ_ACK_REG);
+
 	val = readl(evt->gpt_base + GPT_IRQ_EN_REG);
 	writel(val | GPT_IRQ_ENABLE(timer),
 			evt->gpt_base + GPT_IRQ_EN_REG);
@@ -232,8 +227,6 @@ static void __init mtk_timer_init(struct device_node *node)
 	}
 	rate = clk_get_rate(clk);
 
-	mtk_timer_global_reset(evt);
-
 	if (request_irq(evt->dev.irq, mtk_timer_interrupt,
 			IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) {
 		pr_warn("failed to setup irq %d\n", evt->dev.irq);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT  when setup Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-20 16:30 +0200
  Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT  when setup Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-08-21 16:40 +0200
    Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT  when setup Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-24 10:00 +0200
      Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT  when setup Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-08-24 16:30 +0200
    [PATCH] clockevents/drivers/mtk: Fix spurious interrupt leading to crash Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-24 15:40 +0200
      Re: [PATCH] clockevents/drivers/mtk: Fix spurious interrupt leading  to crash Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-08-24 16:40 +0200
        [PATCH V2] clockevents/drivers/mtk: Fix spurious interrupt leading to crash Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-25 00:00 +0200
          Re: [PATCH V2] clockevents/drivers/mtk: Fix spurious interrupt  leading to crash Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-08-25 15:30 +0200
            Re: [PATCH V2] clockevents/drivers/mtk: Fix spurious interrupt leading  to crash Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-08-26 16:30 +0200
              Re: [PATCH V2] clockevents/drivers/mtk: Fix spurious interrupt  leading to crash Yingjoe Chen <yingjoe.chen@mediatek.com> - 2015-09-04 09:20 +0200
                Re: [PATCH V2] clockevents/drivers/mtk: Fix spurious interrupt leading  to crash Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-09-04 09:40 +0200

csiph-web