Re: [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Luiz Capitulino <lcapitulino@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed
Date	Sat, 22 Aug 2015 23:30:03 +0200
Message-ID	<q0owr-5MB-19@gated-at.bofh.it> (permalink)
References	<q0cbU-4UY-1@gated-at.bofh.it>
X-Original-To	Guenter Roeck <linux@roeck-us.net>
Organization	Red Hat
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.26
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 22 Aug 2015 14:25:50 -0700
X-Original-Message-ID	<20150822142550.254aec3a@redhat.com>
X-Original-References	<1440231047-16256-1-git-send-email-linux@roeck-us.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1211510

Show key headers only | View raw

On Sat, 22 Aug 2015 01:10:47 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> Commit 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
> drops the return code of hrtimer_switch_to_hres(). While doing so, it also
> drops the return statement itself on failure. This may cause a system hang.
> Seen when running arm:multi_v7_defconfig in qemu with devicetree file
> vexpress-v2p-ca9.
> 
> Fixes: 75e3b37d0598 ("hrtimer: Drop return code of hrtimer_switch_to_hres()")
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Thanks for catching it Guenter!

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  kernel/time/hrtimer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> index 5c4fe50e47d3..457a373e2181 100644
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -695,6 +695,7 @@ static void hrtimer_switch_to_hres(void)
>  	if (tick_init_highres()) {
>  		printk(KERN_WARNING "Could not switch to high resolution "
>  				    "mode on CPU %d\n", base->cpu);
> +		return;
>  	}
>  	base->hres_active = 1;
>  	hrtimer_resolution = HIGH_RES_NSEC;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] hrtimer: Fix hang seen if tick_init_highres() failed Guenter Roeck <linux@roeck-us.net> - 2015-08-22 10:20 +0200
  [tip:timers/core] hrtimer: Handle failure of tick_init_highres()   gracefully tip-bot for Guenter Roeck <tipbot@zytor.com> - 2015-08-22 11:10 +0200
  Re: [PATCH -next] hrtimer: Fix hang seen if tick_init_highres()  failed Luiz Capitulino <lcapitulino@redhat.com> - 2015-08-22 23:30 +0200

csiph-web