Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211752

Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation

Show all headers | View raw

Hi Justin,

On 08/20/2015 10:41 AM, Justin Chen wrote:
> Add device tree binding docmentation for the watchdog hardware block
> on bcm7038 and newer SoCs.
>
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
> ---
>   .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt
> new file mode 100644
> index 0000000..adb8260
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt
> @@ -0,0 +1,19 @@
> +BCM7038 Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "brcm,bcm7038-wdt"
> +- reg : Specifies base physical address and size of the registers.
> +
> +Optional properties:
> +
> +- clocks: the clock running the watchdog
> +- clock-frequency: the rate of the clock

Is 'clock-frequency' really needed (and useful), or would it make more sense
to expect the user to configure a fixed clock if nothing else is available ?
How do other drivers handle this ?

Thanks,
Guenter

> +
> +Example:
> +
> +watchdog {
> +	compatible = "brcm,bcm7038-wdt";
> +	clocks = <&upg_fixed>;
> +	reg = <0xf040a7e8 0x16>;
> +};
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] watchdog: driver for BCM7038 and newer chips. Justin Chen <justinpopo6@gmail.com> - 2015-08-20 19:50 +0200
  [PATCH 2/2] watchdog: Watchdog driver for Broadcom Set-Top Box Justin Chen <justinpopo6@gmail.com> - 2015-08-20 19:50 +0200
    Re: [PATCH 2/2] watchdog: Watchdog driver for Broadcom Set-Top Box Guenter Roeck <linux@roeck-us.net> - 2015-08-24 05:30 +0200
  [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation Justin Chen <justinpopo6@gmail.com> - 2015-08-20 19:50 +0200
    Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation Guenter Roeck <linux@roeck-us.net> - 2015-08-24 05:40 +0200
      Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding  documentation Justin Chen <justinpopo6@gmail.com> - 2015-08-25 20:00 +0200
        Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding  documentation Guenter Roeck <linux@roeck-us.net> - 2015-08-25 21:10 +0200
          Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding  documentation Justin Chen <justinpopo6@gmail.com> - 2015-08-25 21:50 +0200

csiph-web