Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1211657

Re: [PATCH 05/11] mlxsw: fix error return code

Show all headers | View raw

Sun, Aug 23, 2015 at 02:11:16AM CEST, Julia.Lawall@lip6.fr wrote:
>Return a negative error code on failure.
>
>A simplified version of the semantic match that finds this problem is as
>follows: (http://coccinelle.lip6.fr/)
>
>// <smpl>
>@@
>identifier ret; expression e1,e2;
>@@
>(
>if (\(ret < 0\|ret != 0\))
> { ... return ret; }
>|
>ret = 0
>)
>... when != ret = e1
>    when != &ret
>*if(...)
>{
>  ... when != ret = e2
>      when forall
> return ret;
>}
>// </smpl>
>
>Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Jiri Pirko <jiri@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 05/11] mlxsw: fix error return code Julia Lawall <Julia.Lawall@lip6.fr> - 2015-08-23 02:30 +0200
  Re: [PATCH 05/11] mlxsw: fix error return code Jiri Pirko <jiri@resnulli.us> - 2015-08-23 21:00 +0200
  Re: [PATCH 05/11] mlxsw: fix error return code David Miller <davem@davemloft.net> - 2015-08-25 22:50 +0200

csiph-web