Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1211347
| From | Yaniv Gardi <ygardi@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v1 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers |
| Date | 2015-08-22 00:20 +0200 |
| Message-ID | <q02Pg-8pP-15@gated-at.bofh.it> (permalink) |
| References | <q02Pf-8pP-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Some of the data structures (like response UPIU) and/or its elements (unused fields) should be cleared before sending out the respective command to UFS device. This change clears the UPIU response data structure for query commands and NOP command before sending out the command. We also initialize the PRDT table length to zero which should take care of commands which doesn't have any data associated with it. We are also clearing the unused fields in request UPIU for NOP command. Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 3428f72..2d3ebca 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1129,6 +1129,8 @@ static void ufshcd_prepare_req_desc_hdr(struct ufshcd_lrb *lrbp, cpu_to_le32(OCS_INVALID_COMMAND_STATUS); /* dword_3 is reserved, hence it is set to 0 */ req_desc->header.dword_3 = 0; + + req_desc->prd_table_length = 0; } /** @@ -1198,6 +1200,7 @@ static void ufshcd_prepare_utp_query_req_upiu(struct ufs_hba *hba, if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC) memcpy(descp, query->descriptor, len); + memset(lrbp->ucd_rsp_ptr, 0, sizeof(struct utp_upiu_rsp)); } static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp) @@ -1210,6 +1213,11 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp) ucd_req_ptr->header.dword_0 = UPIU_HEADER_DWORD( UPIU_TRANSACTION_NOP_OUT, 0, 0, lrbp->task_tag); + /* clear rest of the fields of basic header */ + ucd_req_ptr->header.dword_1 = 0; + ucd_req_ptr->header.dword_2 = 0; + + memset(lrbp->ucd_rsp_ptr, 0, sizeof(struct utp_upiu_rsp)); } /** -- 1.8.5.2 -- QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v1 00/15] Big fixes, retries, handle a race condition Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 03/15] scsi: ufs: verify command tag validity Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
Re: [PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute Rob Herring <robherring2@gmail.com> - 2015-08-23 23:10 +0200
Re: [PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute ygardi@codeaurora.org - 2015-08-25 14:50 +0200
Re: [PATCH v1 15/15] scsi: ufs: add wrapper for retrying sending query attribute ygardi@codeaurora.org - 2015-08-25 15:30 +0200
[PATCH v1 04/15] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 11/15] scsi: ufs: retry failed query flag requests Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Rob Herring <robherring2@gmail.com> - 2015-08-23 23:20 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell ygardi@codeaurora.org - 2015-08-25 14:40 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Rob Herring <robherring2@gmail.com> - 2015-08-25 20:30 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell ygardi@codeaurora.org - 2015-08-27 14:20 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Rob Herring <robherring2@gmail.com> - 2015-08-27 19:30 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell ygardi@codeaurora.org - 2015-08-30 12:00 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell ygardi@codeaurora.org - 2015-08-27 14:30 +0200
Re: [PATCH v1 14/15] scsi: ufs: commit descriptors before setting the doorbell Rob Herring <robherring2@gmail.com> - 2015-08-27 19:10 +0200
[PATCH v1 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 05/15] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 13/15] scsi: ufs: add missing memory barriers Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 12/15] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
[PATCH v1 08/15] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi <ygardi@codeaurora.org> - 2015-08-22 00:20 +0200
csiph-web