[PATCH] driver core: bus: Free the kobject.name if kset_register fails

From	Chen Lin Z <lin.z.chen@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] driver core: bus: Free the kobject.name if kset_register fails
Date	2015-06-09 11:10 +0200
Message-ID	<pznHI-1XB-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

if register two bus with the same name, kset_register will fail.
it need free kobject.name, otherwise there is a memory leak.

Signed-off-by: Chen Lin Z <lin.z.chen@intel.com>
---
 drivers/base/bus.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 79bc203..9375048 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -894,8 +894,10 @@ int bus_register(struct bus_type *bus)
 	priv->drivers_autoprobe = 1;
 
 	retval = kset_register(&priv->subsys);
-	if (retval)
+	if (retval) {
+		kfree(priv->subsys.kobj.name);
 		goto out;
+	}
 
 	retval = bus_create_file(bus, &bus_attr_uevent);
 	if (retval)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] driver core: bus: Free the kobject.name if kset_register fails Chen Lin Z <lin.z.chen@intel.com> - 2015-06-09 11:10 +0200

csiph-web