Re: [PATCH 6/8] mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/8] mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag
Date	2015-06-09 10:00 +0200
Message-ID	<pzmBX-a8-3@gated-at.bofh.it> (permalink)
References	<pqPjQ-7xh-7@gated-at.bofh.it> <pqPjQ-7xh-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 16 May 2015, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request will fail.
> 
> So pass the IRQF_ONESHOT flag in this case.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/mfd/ab8500-debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
> index cdd6f3d..0236cd7 100644
> --- a/drivers/mfd/ab8500-debugfs.c
> +++ b/drivers/mfd/ab8500-debugfs.c
> @@ -2885,7 +2885,7 @@ static ssize_t ab8500_subscribe_write(struct file *file,
>  	}
>  
>  	err = request_threaded_irq(user_val, NULL, ab8500_debug_handler,
> -				   IRQF_SHARED | IRQF_NO_SUSPEND,
> +				   IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT,
>  				   "ab8500-debug", &dev->kobj);
>  	if (err < 0) {
>  		pr_info("request_threaded_irq failed %d, %lu\n",

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 6/8] mfd: ab8500-debugfs: Pass the IRQF_ONESHOT flag Lee Jones <lee.jones@linaro.org> - 2015-06-09 10:00 +0200

csiph-web